Webumenia 2109 search by ID and identifier #1039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
44
to
45
| 'identifier', | ||
| 'id', |
There was a problem hiding this comment.
Is this necessary?
There was a problem hiding this comment.
actually not... just in case you want to filter by them directly. I thought it might be useful. but definitely not necessary.
There was a problem hiding this comment.
Those should be unique so it's basically covered by detail route. I wouldn't add it until we have a use case for it.
rastislav-chynoransky
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This reflect the common use-case when colleagues search by identifier (or directly via ID).
Type of change