Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parameter for outlier tolerance change when is pump on #20

Open
xtrojak opened this issue Nov 22, 2019 · 0 comments
Open

Parameter for outlier tolerance change when is pump on #20

xtrojak opened this issue Nov 22, 2019 · 0 comments
Assignees
@DanDayne
Labels
enhancement New feature or request

Comments

@xtrojak
Copy link
Collaborator

xtrojak commented Nov 22, 2019 •
edited
Loading

In PhenometricsPumpManager, the lower outlier tolerance is changed when pump is turned on (L128) and changed back when pump is turned off (L148). Now the current value is multiplied by a constant (number 2 particularly). This should be generalised to the multiplication by a variable defined in the protocol as pump_on_outlier_factor (feel free to come up with a better name).
@xtrojak xtrojak added the enhancement New feature or request label Nov 22, 2019
DanDayne added a commit that referenced this issue Dec 12, 2019
@DanDayne
#20 outlier factor for when pump is on must be supplied with the prot…
3aeae88 
…ocol if the PBR class is Phenometrics
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DanDayne DanDayne

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@xtrojak @DanDayne