Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Authentication #7

Closed
xtrojak opened this issue Oct 25, 2019 · 2 comments
Closed

Authentication #7

xtrojak opened this issue Oct 25, 2019 · 2 comments
Assignees
Labels
question Further information is requested

Comments

@xtrojak
Copy link
Collaborator

xtrojak commented Oct 25, 2019

Currently it is unclear how the authentication process will be provided in the final product. This should be clarified. Also any login details should be stored in a DB/config file on the side of the server, not in the code.

I can see some work on this was done:

DBmanager/DBapp.py, L18 - L19:

self.username = api.app.config['USERNAME']
self.password = api.app.config['PASSWORD']

yet it wasn't documented.

@xtrojak xtrojak added the question Further information is requested label Oct 25, 2019
@xtrojak xtrojak reopened this Oct 28, 2019
@xtrojak
Copy link
Collaborator Author

xtrojak commented Oct 28, 2019

It is still not clear what is the purpose of verify argument in the request and whether it is necessary .

Also as can be seen in issue #16, the auth argument can be omitted and the request is still working.

@DanDayne
Copy link
Collaborator

certificate.crt file can be added to a request via the verify paramater to ensure verification of server (PBRcontrol) in case we are operating on a larger network, however it is not yet required (verify=False will work just fine over local network)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants