Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert return value of spells to an enum instead of boolean #20

Open
viking-sudo-rm opened this issue Aug 20, 2018 · 0 comments
Open
Labels
low priority Nice to have, but not needed.

Comments

@viking-sudo-rm
Copy link
Member

viking-sudo-rm commented Aug 20, 2018

For example, SpellResult.SUCCESS, SpellResult.ERROR, SpellResult.EVAL_TO_TRUE, SpellResult.EVAL_TO_FALSE.

These enums can have an eval() method which returns the old true or false value.

This is not a must have, but it might be useful for having more informative UI responses after executed spells.

@viking-sudo-rm viking-sudo-rm added the low priority Nice to have, but not needed. label Aug 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
low priority Nice to have, but not needed.
Projects
None yet
Development

No branches or pull requests

1 participant