Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get_db and Postgres.conf needs adjustments #31

Open
micahjohnson150 opened this issue Jul 14, 2021 · 5 comments
Open

get_db and Postgres.conf needs adjustments #31

micahjohnson150 opened this issue Jul 14, 2021 · 5 comments
Labels
bug Something isn't working enhancement New feature or request

Comments

@micahjohnson150
Copy link
Member

After our first live run during hackweek we had a ton of issues with the database.

  • max_connections was 100
  • tcp_keepalives_idle 0

Still sorting through what else needs to be adjusted but this is the starting place. These eventually need to be added to the mod_conf.py script.

@micahjohnson150 micahjohnson150 added bug Something isn't working enhancement New feature or request labels Jul 14, 2021
@micahjohnson150 micahjohnson150 changed the title Postgres.conf needs adjustment get_db and Postgres.conf needs adjustments Jul 14, 2021
@micahjohnson150
Copy link
Member Author

micahjohnson150 commented Jul 14, 2021

Maybe also add pool_pre_ping=True in the get_db functions (aka the pessimistic approach to connection viability) https://docs.sqlalchemy.org/en/14/core/pooling.html#disconnect-handling-pessimistic

@micahjohnson150
Copy link
Member Author

@jomey I am keeping some list of improvements here.

@jomey
Copy link
Member

jomey commented Jul 14, 2021

Adding the discussed contextmanager idea:
https://docs.sqlalchemy.org/en/14/core/connections.html#basic-usage

@jomey
Copy link
Member

jomey commented Sep 12, 2024

@micahjohnson150 - Sounds like this issue should be transferred to the snowexdb repo?
Also, the API class that handles the connection should be a big difference maker

@micahjohnson150
Copy link
Member Author

Yep!

@jomey jomey transferred this issue from SnowEx/snowexsql Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants