-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a coding standards GA to fix code with Laravel Pint. #221
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #221 +/- ##
=========================================
Coverage 53.49% 53.49%
Complexity 78 78
=========================================
Files 10 10
Lines 243 243
=========================================
Hits 130 130
Misses 113 113 ☔ View full report in Codecov by Sentry. |
See comments on other PR |
Will it run correctly for contributors as well? |
It should, my only concern is this : WDYT ? |
f4866e7
to
dbb2a2c
Compare
Introducing the PAT solve this. This PR is ready to be reviewed @atymic |
Sorry if i wasn't clear @lucasmichot, I meant just run the lint only (not fix) on the pull_request trigger, so we can know if theres issues |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This PR adds a coding standards GA to fix code with Laravel Pint.
It also fixes the code to match those coding standards