Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a coding standards GA to fix code with Laravel Pint. #221

Closed
wants to merge 6 commits into from

Conversation

lucasmichot
Copy link
Member

This PR adds a coding standards GA to fix code with Laravel Pint.

It also fixes the code to match those coding standards

@codecov
Copy link

codecov bot commented Aug 23, 2023

Codecov Report

Attention: Patch coverage is 37.50000% with 5 lines in your changes missing coverage. Please review.

Project coverage is 53.49%. Comparing base (df5e45b) to head (9f09c8c).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
src/Helpers/ConfigRetriever.php 33.33% 2 Missing ⚠️
src/OAuth1/AbstractProvider.php 0.00% 2 Missing ⚠️
src/ServiceProvider.php 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master     #221   +/-   ##
=========================================
  Coverage     53.49%   53.49%           
  Complexity       78       78           
=========================================
  Files            10       10           
  Lines           243      243           
=========================================
  Hits            130      130           
  Misses          113      113           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@atymic
Copy link
Member

atymic commented Aug 27, 2023

See comments on other PR
SocialiteProviders/Providers#1064 (review)

@atymic
Copy link
Member

atymic commented Aug 31, 2023

Will it run correctly for contributors as well?

@lucasmichot
Copy link
Member Author

@lucasmichot
Copy link
Member Author

Introducing the PAT solve this.

This PR is ready to be reviewed @atymic

@atymic
Copy link
Member

atymic commented Sep 8, 2023

Sorry if i wasn't clear @lucasmichot, I meant just run the lint only (not fix) on the pull_request trigger, so we can know if theres issues

Copy link

stale bot commented Dec 15, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Dec 15, 2023
@lucasmichot lucasmichot closed this Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants