What's the best way to configure Guzzle options for Socialite providers?

[rvanbaalen]

I want to configure proxy settings for the Socialite providers I use in my project.

For instance, when I use the Todoist provider:

• I extend the TodoistExtendSocialite class
• In this class, I point to my custom Todoist provider class, which extends the default Trello Provider class.
• In the __construct of this custom class, I do:

OAuth2 providers need a custom Provider class:

use HasProxy;

public function __construct(Request $request, $clientId, $clientSecret, $redirectUrl, $guzzle = [])
{
    parent::__construct($request, $clientId, $clientSecret, $redirectUrl, $guzzle);
    $this->guzzle = $this->addConfiguredProxy($this->guzzle);
}

OAuth1 providers need a custom Server class:

OAuth1 providers need a custom Server instead of a custom Provider. Trello example:

class Server extends \SocialiteProviders\Trello\Server
{
    use HasProxy;

    protected array $guzzle = [];

    public function __construct($clientCredentials, SignatureInterface $signature = null)
    {
        parent::__construct($clientCredentials, $signature);
        $this->guzzle = $this->addConfiguredProxy($this->guzzle);
    }

    public function createHttpClient(): Client
    {
        return new Client($this->guzzle);
    }
}

I abstracted this piece of code to a trait because I use it in mutliple providers in my project.

use GuzzleHttp\RequestOptions;

trait HasProxy
{
    public function addConfiguredProxy($guzzle = []): array
    {
        if (config('app.proxy')) {
            $requestOptions[RequestOptions::PROXY] = [
                'http' => config('app.proxy'),
                'https' => config('app.proxy_https')
            ];

            $guzzle = array_merge($guzzle, $requestOptions);
        }

        return $guzzle;
    }
}

Is there a better way to define Guzze settings for Socialite providers?

Edit; turns out Trello wasn't a good example since they use the OAuth1 flow, edited this for Todoist.