SLVSCODE-738 The "TLS certificate trust" dialog can show erroneous data #560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kirill-knize-sonarsource
force-pushed
the
fix/kk/ssl-dialog-password
branch
from
737751d
to
760d665
Compare
|
kirill-knize-sonarsource
changed the title
|
I believe we should have a chat with a PM about the best way to fix this. This change fixes the "default" behavior but the modal will still show incorrect data if SSL parameters are provided (e.g. if users configure a custom trust store). |
|
A recent firewall change at my organization has just started triggering this dialog. Would it also be possible to indicate either in the dialog or in the verbose logging what the URL that caused the trust issue actually is? with verbose logging enabled, the output from the extension merely says something like "Request failed." |
|
Fixed by #616 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.