Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUILD-5219 use Hashicorp Vault to retrieve secrets #583

Merged
merged 3 commits into from
Jun 5, 2024
Merged

BUILD-5219 use Hashicorp Vault to retrieve secrets #583

merged 3 commits into from
Jun 5, 2024

Conversation

sebastienvermeille
Copy link
Contributor

@sebastienvermeille sebastienvermeille commented Jun 4, 2024 •
edited
Loading

BUILD-5219 use Hashicorp Vault to retrieve secrets

Changes

  • Retrieve secrets from Hashicorp Vault instead of the one stored in GitHub repository
    That way the new values are used/updated in Vault.

    It should resolve issues of release

How was it tested?

@sebastienvermeille
BUILD-5219 Use Hashicorp Vault to retrieve VSCE_TOKEN
a79b4b3 
That way it retrieves an up-to-date secret
@sebastienvermeille sebastienvermeille self-assigned this Jun 4, 2024
@sebastienvermeille
BUILD-5219 Use Hashicorp Vault to retrieve OPENVSX_TOKEN
a0de38a 
That way it retrieves an up-to-date secret
@sebastienvermeille sebastienvermeille force-pushed the feat/svermeille/BUILD-5219-sonarlint-vscode-use-vault branch from 4df6a23 to a0de38a Compare June 4, 2024 12:17
@sebastienvermeille sebastienvermeille marked this pull request as ready for review June 4, 2024 13:41
jblievremont
jblievremont reviewed Jun 4, 2024
View reviewed changes
Copy link
Member

@jblievremont jblievremont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, could you please also update the credentials check workflow in .github/workflows/credcheck.yml? This way we can manually check that it gets the correct value from Vault.

@sebastienvermeille
BUILD-5219 Update credcheck.yml workflow accordingly
bdeb830 
That way it also use Hashicorp Vault secrets
@sonarqube-next SonarQube-Next
Copy link

sonarqube-next bot commented Jun 4, 2024

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@sebastienvermeille
Copy link
Contributor Author

Looks good to me, could you please also update the credentials check workflow in .github/workflows/credcheck.yml? This way we can manually check that it gets the correct value from Vault.

Hi @jblievremont I implemented it in this new commit bdeb830

jblievremont
jblievremont approved these changes Jun 4, 2024
View reviewed changes
Copy link
Member

@jblievremont jblievremont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! And I see that you've already run the credentials check workflow, thanks!

LGTM 🚢

@sebastienvermeille sebastienvermeille merged commit 1b3afc3 into master Jun 5, 2024
10 checks passed
@sebastienvermeille sebastienvermeille deleted the feat/svermeille/BUILD-5219-sonarlint-vscode-use-vault branch June 5, 2024 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jblievremont jblievremont jblievremont approved these changes

@sophio-japharidze-sonarsource sophio-japharidze-sonarsource Awaiting requested review from sophio-japharidze-sonarsource

Assignees

@sebastienvermeille sebastienvermeille

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sebastienvermeille @jblievremont