SLVSCODE-834 store SonarCloud tokens properly #613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -91,7 +91,7 @@ export function confirmConnectionDetailsAndSave(context: vscode.ExtensionContext | |||
| if (isSonarCloud) { | |||
| const sonarCloudToken = token || await ConnectionSettingsService.instance.getServerToken(serverUrlOrOrganizationKey); | |||
| const connection = { | |||
| sonarCloudToken, | |||
| token: sonarCloudToken, | |||
There was a problem hiding this comment.
I would suggest the following change (and similar below for the SQ connection):
const connection: SonarCloudConnection = {
token: sonarCloudToken,
connectionId: serverUrlOrOrganizationKey,
disableNotifications: false,
organizationKey: serverUrlOrOrganizationKey
};
With this explicit type declaration, the TS compiler correctly flags the sonarCloudToken property as invalid for the SonarCloudConnection type, instead of silently accepting it with the as cast.
sophio-japharidze-sonarsource
force-pushed
the
SLVSCODE-834_store_sc_token_properly
branch
from
b0d0db1
to
1386391
Compare
|
sophio-japharidze-sonarsource
deleted the
SLVSCODE-834_store_sc_token_properly
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SLVSCODE-834
It is amazing how many hidden problems this was causing 🥲