Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SLVSCODE-738 show correct default values and setting for actual value in SSL dialog #616

Merged
merged 2 commits into from
Aug 30, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion scripts/dependencies.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
{
"groupId": "org.sonarsource.sonarlint.ls",
"artifactId": "sonarlint-language-server",
"version": "3.9.0.75429",
"version": "3.10.0.75468",
"output": "server/sonarlint-ls.jar"
},
{
Expand Down
5 changes: 3 additions & 2 deletions src/util/showMessage.ts
Original file line number Diff line number Diff line change
Expand Up @@ -77,8 +77,9 @@ export async function showSslCertificateConfirmationDialog(cert: SslCertificateC
Valid from: ${cert.validFrom}\n
Valid to: ${cert.validTo}\n
${fingerprints}
If you trust the certificate, it will be saved in truststore ${cert.truststorePath}\n
Default password: changeit\n
If you trust the certificate, by default it will be saved in truststore '${cert.truststorePath}'\n
Default password: sonarlint\n
For actual values of truststore path and password, check the 'sonarlint.ls.vmargs' setting.\n
Consider removing connection if you don't trust the certificate\n`,
{ modal: true }, dontTrust, trust);
return dialogResponse === trust;
Expand Down