Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SLLS-226 properly cancel automatic Connection setup #617

Merged
merged 1 commit into from
Aug 29, 2024
Merged

SLLS-226 properly cancel automatic Connection setup #617

merged 1 commit into from
Aug 29, 2024

Conversation

sophio-japharidze-sonarsource
Copy link
Contributor

@sophio-japharidze-sonarsource sophio-japharidze-sonarsource commented Aug 28, 2024 •
edited by jira bot
Loading

SLLS-226

We should cancel the automatic Connection setup if

  • User explicitly cancels it
  • User decides to open Connected Mode docs
  • We default back to old SonarQube setup (when we don't have access to the token immediately)

Throwing cancellation exception from the client and returning null to the Language Server will result in unused tokens being revoked immediately.

@sonarqube-next SonarQube-Next
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
15.4% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@sophio-japharidze-sonarsource sophio-japharidze-sonarsource merged commit 6eed6c2 into master Aug 29, 2024
14 checks passed
@sophio-japharidze-sonarsource sophio-japharidze-sonarsource deleted the SLLS-226_throw_cancellation_exception branch August 29, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jblievremont jblievremont jblievremont approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sophio-japharidze-sonarsource @jblievremont