From 1c3ead9656d2e79d3bd1cf71158944bf620f6910 Mon Sep 17 00:00:00 2001 From: Jean-Baptiste Lievremont Date: Mon, 16 Sep 2024 11:40:59 +0200 Subject: [PATCH 1/2] SLVSCODE-847 Prevent clogging of dev console with messages from directory traversal --- src/connected/autobinding.ts | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/connected/autobinding.ts b/src/connected/autobinding.ts index e33c93c9b..b52bfcdfe 100644 --- a/src/connected/autobinding.ts +++ b/src/connected/autobinding.ts @@ -306,6 +306,11 @@ export class AutoBindingService implements FileSystemSubscriber { private async listJsonFilesInDotSonarLint(folderUri: vscode.Uri) { const dotSonarLintUri = vscode.Uri.joinPath(folderUri, '.sonarlint'); try { + // First check that the directory exists with `stat` to avoid errors logged by `readDirectory` + const dotSonarLintStats = await vscode.workspace.fs.stat(dotSonarLintUri); + if ((dotSonarLintStats.type | vscode.FileType.Directory) === 0) { + return []; + } const baseFiles = await vscode.workspace.fs.readDirectory(dotSonarLintUri); const foundFiles: Array = []; for (const [name, type] of baseFiles) { From ba9dbc277c22a72b5b5680a0c3a6f2cb0e56ef0b Mon Sep 17 00:00:00 2001 From: Jean-Baptiste Lievremont Date: Mon, 16 Sep 2024 17:11:07 +0200 Subject: [PATCH 2/2] SLVSCODE-847 Apply PR feedback --- src/connected/autobinding.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/connected/autobinding.ts b/src/connected/autobinding.ts index b52bfcdfe..3e25aa9e9 100644 --- a/src/connected/autobinding.ts +++ b/src/connected/autobinding.ts @@ -308,7 +308,7 @@ export class AutoBindingService implements FileSystemSubscriber { try { // First check that the directory exists with `stat` to avoid errors logged by `readDirectory` const dotSonarLintStats = await vscode.workspace.fs.stat(dotSonarLintUri); - if ((dotSonarLintStats.type | vscode.FileType.Directory) === 0) { + if ((dotSonarLintStats.type & vscode.FileType.Directory) === 0) { return []; } const baseFiles = await vscode.workspace.fs.readDirectory(dotSonarLintUri);