From 69f236fd20dd04928b47b0eee68340cd45bade3b Mon Sep 17 00:00:00 2001
From: "Christian Y. Brenninkmeijer"
 <christian.brenninkmeijer@manchester.ac.uk>
Date: Tue, 28 May 2024 06:27:30 +0100
Subject: [PATCH 1/2] SupportScripts python_checks

---
 .github/workflows/python_actions.yml | 114 ++-------------------------
 1 file changed, 8 insertions(+), 106 deletions(-)

diff --git a/.github/workflows/python_actions.yml b/.github/workflows/python_actions.yml
index c180acab8..23817850e 100644
--- a/.github/workflows/python_actions.yml
+++ b/.github/workflows/python_actions.yml
@@ -16,111 +16,13 @@
 # For more information see: https://help.github.com/actions/language-and-framework-guides/using-python-with-github-actions
 
 name: Python Actions
-
 on: [push]
-env:
-  BASE_PKG: pacman
-
 jobs:
-  test:
-    runs-on: ubuntu-latest
-    timeout-minutes: 10
-    strategy:
-      matrix:
-        python-version: [3.8, 3.9, "3.10", "3.11", "3.12"]
-
-    steps:
-    - name: Set up Python ${{ matrix.python-version }}
-      uses: actions/setup-python@v5
-      with:
-        python-version: ${{ matrix.python-version }}
-
-    - name: Checkout
-      uses: actions/checkout@v4
-    - name: Checkout SupportScripts
-      uses: actions/checkout@v4
-      with:
-        repository: SpiNNakerManchester/SupportScripts
-        path: support
-
-    - name: Install pip, etc
-      uses: ./support/actions/python-tools
-    - name: Install mypy
-      run: pip install mypy
-
-    - name: Install Spinnaker Dependencies
-      uses: ./support/actions/install-spinn-deps
-      with:
-        repositories: SpiNNUtils SpiNNMachine
-        install: true
-
-    - name: Run Install
-      uses: ./support/actions/run-install
-
-    - name: Test with pytest
-      uses: ./support/actions/pytest
-      with:
-        tests: unittests
-        coverage: ${{ matrix.python-version == 3.12 }}
-        cover-packages: ${{ env.BASE_PKG }}
-        coveralls-token: ${{ secrets.GITHUB_TOKEN }}
-
-    - name: Lint with flake8
-      run: flake8 $BASE_PKG unittests
-
-    - name: Lint with pylint
-      uses: ./support/actions/pylint
-      with:
-        package: ${{ env.BASE_PKG }}
-        exitcheck: 31 # Action fails on any message
-        language: en_GB
-        rcfile: global_strict
-
-    - name: Lint with mypy
-      run: mypy $BASE_PKG
-
-  validate:
-    runs-on: ubuntu-latest
-    timeout-minutes: 10
-    strategy:
-      matrix:
-        python-version: [3.12]
-
-    steps:
-    - name: Set up Python ${{ matrix.python-version }}
-      uses: actions/setup-python@v5
-      with:
-        python-version: ${{ matrix.python-version }}
-    - name: Checkout
-      uses: actions/checkout@v4
-    - name: Checkout SupportScripts
-      uses: actions/checkout@v4
-      with:
-        repository: SpiNNakerManchester/SupportScripts
-        path: support
-    - name: Install pip, etc
-      uses: ./support/actions/python-tools
-    - name: Install Spinnaker Dependencies
-      uses: ./support/actions/install-spinn-deps
-      with:
-        repositories: SpiNNUtils SpiNNMachine
-        install: true
-    - name: Run Install
-      uses: ./support/actions/run-install
-
-    - name: Run rat copyright enforcement
-      uses: ./support/actions/check-copyrights
-      with:
-        config_file: rat_asl20.xml
-    - name: Validate all XML
-      if: false
-      uses: ./support/actions/validate-xml
-      with:
-        package: ${{ env.BASE_PKG }}
-    - name: Build documentation with sphinx
-      uses: ./support/actions/sphinx
-      with:
-        directory: doc/source
-    - name: Validate CITATION.cff
-      uses: dieghernan/cff-validator@main
-
+  call:
+    uses: SpiNNakerManchester/SupportScripts/.github/workflows/python_checks.yml@main
+    with:
+      base-package: pacman
+      dependencies: SpiNNUtils SpiNNMachine
+      test_directories: unittests
+      flake8-packages: pacman unittests
+    secrets: inherit

From 600d6578a49ee6a41b8035ef198196c992e54012 Mon Sep 17 00:00:00 2001
From: "Christian Y. Brenninkmeijer"
 <christian.brenninkmeijer@manchester.ac.uk>
Date: Tue, 28 May 2024 09:19:10 +0100
Subject: [PATCH 2/2] set variable before use

---
 pacman/operations/router_algorithms/application_router.py | 1 +
 1 file changed, 1 insertion(+)

diff --git a/pacman/operations/router_algorithms/application_router.py b/pacman/operations/router_algorithms/application_router.py
index bda9ea43b..eeb2a11b5 100644
--- a/pacman/operations/router_algorithms/application_router.py
+++ b/pacman/operations/router_algorithms/application_router.py
@@ -957,6 +957,7 @@ def _convert_a_route(
 
         processor_ids: List[int] = list()
         link_ids: List[int] = list()
+        next_incoming_link: _OptInt = None
         for (link, next_hop) in route.children:
             if link is not None:
                 link_ids.append(link)