Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unused code keep or nuke? #460

Open
Christian-B opened this issue Aug 23, 2022 · 7 comments
Open

Unused code keep or nuke? #460

Christian-B opened this issue Aug 23, 2022 · 7 comments
Labels
question

Comments

@Christian-B
Copy link
Member

ConstantSDRAMMachinePartition only used if GFE test for it
@Christian-B
Copy link
Member Author

DestinationSegmentedSDRAMMachinePartition also only used in GFE tests

@Christian-B
Copy link
Member Author

ZonedRoutingTableGenerator unused, untested and does not use view

@Christian-B
Copy link
Member Author

Discussed with @rowleya and SDRAMMachinePartition classes may have a use so added tests in coverage branch

@Christian-B
Copy link
Member Author

ZonedRoutingTableGenerator not tested not used

@Christian-B
Copy link
Member Author

ElementAllocatorAlgorithm see: #465

@Christian-B
Copy link
Member Author

pacman/utilities/algorithm_utilities/routing_algorithm_utilities.py
A lot of code only used by ner_route so the question is do we keep ner_route in which case we should do some testing.

most_direct_route method not used at all.

@Christian-B
Copy link
Member Author

Field
pacman/utilities/utility_objs/field.py

@Christian-B Christian-B mentioned this issue Sep 16, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Christian-B