From 7ee9b8a7fd88279490e7df5436237c387aa29a42 Mon Sep 17 00:00:00 2001 From: "Christian Y. Brenninkmeijer" Date: Wed, 3 Jan 2024 09:37:39 +0000 Subject: [PATCH 1/4] fail on ANY pylint message --- .github/workflows/python_actions.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/python_actions.yml b/.github/workflows/python_actions.yml index f70ac57d17..60b8fb67f4 100644 --- a/.github/workflows/python_actions.yml +++ b/.github/workflows/python_actions.yml @@ -89,6 +89,7 @@ jobs: uses: ./support/actions/pylint with: package: ${{ env.BASE_PKG }} + exitcheck: 31 # Action fails on any message language: en_GB - name: Lint with mypy run: mypy ${{ env.BASE_PKG }} From 126583d8614bd85a5236e9c8d7876154a9d48991 Mon Sep 17 00:00:00 2001 From: "Christian Y. Brenninkmeijer" Date: Fri, 5 Jan 2024 06:49:37 +0000 Subject: [PATCH 2/4] spelling fix and exceptions --- .pylint_dict.txt | 142 +++++++++--------- .../models/common/local_only_2d_common.py | 2 +- 2 files changed, 73 insertions(+), 71 deletions(-) diff --git a/.pylint_dict.txt b/.pylint_dict.txt index 6c3b9b7737..d476907b71 100644 --- a/.pylint_dict.txt +++ b/.pylint_dict.txt @@ -24,124 +24,126 @@ Petrut Vogels # Our abbreviations/names -MPI gsyn -spinnman +MPI +Omnibot pacman +pushbot spalloc +spinnman Omnibot -pushbot # Our "special" words -multapse -spiketrain -spiketrains +analog +componentised +config heatmap -multiplicator generatable -componentised -rng +multapse +multiplicator +or'ed PLoS +pn rewirings -analog +rng +spiketrain +spiketrains stdev -or'ed -pn -config # Our Python types -ApplicationGraph -AbstractVertex -ApplicationVertex -MachineVertex +AbstractCurrentSource +AbstractMulticastControllableDevice AbstractPopulationVertex +AbstractSDRAM +AbstractSynapseType +AbstractVertex ApplicationEdge +ApplicationEdgePartition +ApplicationGraph +ApplicationVertex +CommonRegions +ConnectionHolder +ConstantSDRAM +CoreSubset +CoreSubsets +DataSpecificationGenerator DataType -MachineEdge -ProjectionApplicationEdge DelayedApplicationEdge DelayExtensionVertex -ApplicationEdgePartition -SourceSegmentedSDRAMMachinePartition -SynapseRegionReferences +EIEIOPrefix +EIEIOType +ExecutableTargets +FPGAConnection +GeneratorData +IDMixin +MachineEdge +MachineVertex +MDSlice +MultiRegionSDRAM +NeuronRegions +ProjectionApplicationEdge +PopulationApplicationVertex PopulationBase PopulationView -IDMixin -RandomDistribution -ConnectionHolder -FPGAConnection ProgressBar -AbstractSynapseType +RandomDistribution +SourceSegmentedSDRAMMachinePartition +SpinnmanIOException SynapseInformation +SynapseRegionReferences SynapseRegions -ExecutableTargets -AbstractSDRAM -ConstantSDRAM VariableSDRAM -MultiRegionSDRAM -AbstractMulticastControllableDevice -CommonRegions -NeuronRegions -DataSpecificationGenerator -CoreSubset -CoreSubsets -SpinnmanIOException -AbstractCurrentSource -GeneratorData -EIEIOType -EIEIOPrefix -RandomDistribtuion # Others' Python types -NumpyRNG -NativeRNG -TemplateEngine -BaseStructure +AnalogSignal BaseIO -FileIO +BaseStructure +ChannelIndex CSet +ctype +dtype +FileIO +GSLRNG +NumpyRNG +NativeRNG NeuronCurrentSource -AnalogSignal +RandomState SpikeTrain +TemplateEngine StandardTextFile -dtype UnitTime -RandomState -ChannelIndex -ctype -GSLRNG # Python packages +baseio +connset +ctypes csa +cset datetime +graphviz neo pynn pyNN -standardmodels -graphviz rawio -baseio +standardmodels struct -cset -connset unitquantity -ctypes # Misc (arguments, etc.) -Wi -sdram -csv +addr cellclass cellparams -structs -rd -tstop -params +csv csvfile db dt -vals -addr -simtime eieio +params +rd +sdram +simtime +structs +tstop +vals +Wi ylabel diff --git a/spynnaker/pyNN/models/common/local_only_2d_common.py b/spynnaker/pyNN/models/common/local_only_2d_common.py index c4845c4630..322a9c1270 100644 --- a/spynnaker/pyNN/models/common/local_only_2d_common.py +++ b/spynnaker/pyNN/models/common/local_only_2d_common.py @@ -56,7 +56,7 @@ def get_div_const(value): def get_delay_for_source(incoming): """ Get the vertex which will send data from a given source projection, - along with the delay stage and locally-handled delay valule + along with the delay stage and locally-handled delay value :param Projection incoming: The incoming projection to get the delay from :return: The vertex, the local delay, the delay stage From 7ea574e5f8dfa7687eb6be5c5f0a2e66ffaa7a0a Mon Sep 17 00:00:00 2001 From: "Christian Y. Brenninkmeijer" Date: Fri, 5 Jan 2024 07:22:27 +0000 Subject: [PATCH 3/4] accept spelling RandomDistribtuion --- .pylint_dict.txt | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.pylint_dict.txt b/.pylint_dict.txt index d476907b71..2aa6378e31 100644 --- a/.pylint_dict.txt +++ b/.pylint_dict.txt @@ -94,7 +94,7 @@ SynapseRegionReferences SynapseRegions VariableSDRAM -# Others' Python types +# Others' Python types (including PYNN terms) AnalogSignal BaseIO BaseStructure @@ -107,6 +107,7 @@ GSLRNG NumpyRNG NativeRNG NeuronCurrentSource +RandomDistribtuion RandomState SpikeTrain TemplateEngine From 844ef5f96a72e977c9eb9cc5320591a84bcd0365 Mon Sep 17 00:00:00 2001 From: "Christian Y. Brenninkmeijer" Date: Mon, 8 Jan 2024 07:23:28 +0000 Subject: [PATCH 4/4] ModuleType --- .pylint_dict.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/.pylint_dict.txt b/.pylint_dict.txt index 2aa6378e31..564be9322d 100644 --- a/.pylint_dict.txt +++ b/.pylint_dict.txt @@ -79,6 +79,7 @@ IDMixin MachineEdge MachineVertex MDSlice +ModuleType MultiRegionSDRAM NeuronRegions ProjectionApplicationEdge