Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.7.10]Multiplier for balance should be a double not int #115

Open
tytannial opened this issue Feb 26, 2017 · 0 comments
Open

[1.7.10]Multiplier for balance should be a double not int #115

tytannial opened this issue Feb 26, 2017 · 0 comments

Comments

@tytannial
Copy link

tytannial commented Feb 26, 2017

modifier = Math.max(modifier + Config.modifier, 0);
multiplier = Math.max(multiplier + Config.multiplier, 0);

cost = (base + modifier) * multiplier;
Negative multiplier is bug in those code.
Min cost should be 1 not 0, there need a check for it.
Integer multiplier seems useless in reducing materials by percentage.

@tytannial tytannial changed the title Multiplier for balance should be a non negative double not int [1.7.10]Multiplier for balance should be a non negative double not int Feb 26, 2017
@tytannial tytannial changed the title [1.7.10]Multiplier for balance should be a non negative double not int [1.7.10]Multiplier for balance should be a double not int Feb 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant