Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[helm]support config override in starrocksFESpec/starrocksBeSpec/starrocksCnSpec #494

Open
mingmxu opened this issue Apr 1, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@mingmxu
Copy link
Contributor

mingmxu commented Apr 1, 2024

Describe the current behavior

Currently all the config in starrocks helm chart are taken as a block, see the code here. As a result, partial update is not supported.

Describe the enhancement

Support partial update in values.yaml to simplify configuration changes.

Additional context

cc @dengliu @yandongxiao

@mingmxu mingmxu added the enhancement New feature or request label Apr 1, 2024
@yandongxiao
Copy link
Collaborator

‌‌The "partial update" you mentioned refers to adding or updating some additional configurations in other values.yaml files on top of a certain base values.yaml configuration?

@mingmxu
Copy link
Contributor Author

mingmxu commented Apr 1, 2024

‌‌The "partial update" you mentioned refers to adding or updating some additional configurations in other values.yaml files on top of a certain base values.yaml configuration?

Yes,

@yandongxiao
Copy link
Collaborator

This is a bit challenging because the current type of config is a string. We need to parse this string in _helper, convert it into the format of a map, and finally merge it with the default values. I tried to write it, but failed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants