Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid uploading Plugins with enabled "debug" flag #295

Open
Fisch03 opened this issue Mar 18, 2023 · 1 comment
Open

Avoid uploading Plugins with enabled "debug" flag #295

Fisch03 opened this issue Mar 18, 2023 · 1 comment
Assignees
@TrainDoctor @SkyLeite
Labels
bug Something isn't working

Comments

@Fisch03
Copy link
Contributor

Fisch03 commented Mar 18, 2023

There are no measures in place to avoid a plugin being uploaded with the debug flag being enabled in plugin.json.

It should either be removed automatically before uploading or not be uploaded at all.
@TrainDoctor TrainDoctor self-assigned this Mar 18, 2023
@TrainDoctor TrainDoctor added the bug Something isn't working label Mar 18, 2023
@github-project-automation github-project-automation bot moved this to 🆕 New in SDH Tracker Mar 18, 2023
@TrainDoctor
Copy link
Member

Debug often left in by developers by accident, I think I will simply remove the debug flag via CI trim.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TrainDoctor TrainDoctor

@SkyLeite SkyLeite

Labels
bug Something isn't working
Projects
SDH Tracker
Status: 🆕 New
Milestone
No milestone
Development

No branches or pull requests
3 participants
@TrainDoctor @SkyLeite @Fisch03