From e9e5dd2c5c6f0b26848a480190937d1332c860e9 Mon Sep 17 00:00:00 2001
From: Jan Eger <Jan.Eger@Online.de>
Date: Thu, 1 Apr 2021 10:54:35 +0200
Subject: [PATCH] updated OrderValidator for stop, limit and amount

---
 src/order/OrderValidator.ts | 26 ++++++++++++++++++++++++--
 1 file changed, 24 insertions(+), 2 deletions(-)

diff --git a/src/order/OrderValidator.ts b/src/order/OrderValidator.ts
index 70e5e66..eeab0c6 100644
--- a/src/order/OrderValidator.ts
+++ b/src/order/OrderValidator.ts
@@ -1,6 +1,9 @@
 import { UnprocessableEntityException } from '@nestjs/common';
 import { PlaceOrderDto } from './dtos/PlaceOrder.dto';
 
+const MAX_AMOUNT = 10000;
+const MAX_DIGITS = 2;
+
 export class OrderValidator {
   public static validate(order: PlaceOrderDto): PlaceOrderDto {
     const {
@@ -19,9 +22,10 @@ export class OrderValidator {
         'Amount needs to be assigned and of type number',
       );
     }
-    if (amount < 0) {
+
+    if (amount < 0 || amount > MAX_AMOUNT) {
       throw new UnprocessableEntityException(
-        'Amount must be greater than zero',
+        'Amount needs to be between 1 and 10000.',
       );
     }
 
@@ -61,6 +65,15 @@ export class OrderValidator {
       );
     }
 
+    if (limit && limit % 1 != 0) {
+      let limit_digits = limit.toString().split('.');
+      if (limit_digits[1].length > MAX_DIGITS) {
+        throw new UnprocessableEntityException(
+          'Limit cannot have more than 2 digits',
+        );
+      }
+    }
+
     if (stop && typeof stop !== 'number') {
       throw new UnprocessableEntityException('Stop needs to be of type number');
     }
@@ -69,6 +82,15 @@ export class OrderValidator {
       throw new UnprocessableEntityException('Stop must be greater than zero');
     }
 
+    if (stop && stop % 1 != 0) {
+      let stop_digits = stop.toString().split('.');
+      if (stop_digits[1].length > MAX_DIGITS) {
+        throw new UnprocessableEntityException(
+          'Stop cannot have more than 2 digits',
+        );
+      }
+    }
+
     return {
       shareId: order.shareId,
       amount: order.amount,