-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Does core need providers? #11
Comments
"core only handles the webhooks to trigger drones" Without providers, how can the webhooks be setup and configured? :)
|
Ok what I meant by "no providers" is no provider specific APIs apart from webhooks and auth. Should have been more clear. Really we need to be able to trigger by provider, and convert the providers trigger data to something structured/generic. Setting up webhooks doesn't even have to be automatic right away, since even now we have issues with it, and manual setup isn't so bad (only once per project). There doesn't need to be any cloning or getting a file (strider.json), or handling ssh keys.. |
I agree that we don't really need providers in the classical sense. If someone needs a functionality where you look into the repo in order determine what to do with the job before sending it to a drone we can implement this a plugin. BTW: I plan to implement such a plugin very soon after having the basic functionality of core + drone implemented. The use case would be:
|
I'm just wondering if Core really needs providers e.g. Github, Bitbucket, etc, since the work will be done by the drones, core only handles the webhooks to trigger drones.
What would be the benefit of providers on core?
The text was updated successfully, but these errors were encountered: