Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade jackson dependencies and publish a new beta #79

Open
FlorianBruckner opened this issue Jan 5, 2020 · 2 comments
Open

Upgrade jackson dependencies and publish a new beta #79

FlorianBruckner opened this issue Jan 5, 2020 · 2 comments

Comments

@FlorianBruckner
Copy link

We're still maintaining a few applications using stripes framework and even started using the @RestActionBean from 1.7.0-beta4.

Unfortunately we're hit by a nasty dependency thing with jackson - the version used for compiling Stripes leads to a wrong execution path inside jackson. We can work around most parts (for example, by using our own version of JsonResolution which we've been using for some time now), but this fails for error handling:

Caused by: java.lang.ClassCastException: com.fasterxml.jackson.databind.ser.std.MapProperty cannot be cast to com.fasterxml.jackson.databind.ser.BeanPropertyWriter
	at com.fasterxml.jackson.databind.ser.impl.SimpleBeanPropertyFilter$1.serializeAsField(SimpleBeanPropertyFilter.java:93)
	at com.fasterxml.jackson.databind.ser.std.MapSerializer.serializeFilteredFields(MapSerializer.java:883)
	... 59 more

This specific exception could be avoided by compiling stripes with a newer version of jackson as dependency.

There are already PR for updating the dependencies that were automatically created by a bot, may I suggest to acccept those PRs and probably create a beta5 for then?

If no one is up to doing this, I volounteer to doing it myself.

@mprins
Copy link

mprins commented Jan 5, 2020

I started #71 in August 2018 but it didn't get any traction

@mprins
Copy link

mprins commented Jan 5, 2020

also #78 , #77 and #76 are hitting an API incompatibility, eg: https://travis-ci.org/StripesFramework/stripes/builds/611234005#L6394-L6435

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants