-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Добавил недостающие руты в меню О нас в хедер #417
Conversation
…а для всех страниц, без привязки к бизнес-сущностям. Добавил страницы Политика безопасности и Условия соглашения. Они без контента, но и на оригинальном сайте они тоже без контента. оставил TODO для наполнения этих страниц.
…ницы отзывов назывался reviews, а страница с обзорами тоже reviews. Теперь отзывы это feedbacks. Кроме того добавил в shared функцию прокрутки скрола в начало, для исправления поведения react-router. Добавил вызов функции на страницы отзывов и продукта.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Отличная работа, парочка незначительных улучшений и можно мержить
<Heading type={HeadingType.SMALL}>Основной магазин</Heading> | ||
<ul> | ||
<li className={styles.contacts__text}>Телефон</li> | ||
<li>+7 977 848-02-28</li> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
давай здесь текст в списках тоже в тайпографи обернем
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
сделал
<div className={styles.contacts__block}> | ||
<Heading type={HeadingType.SMALL}>Наши реквизиты</Heading> | ||
<div> | ||
<p>Банковские и юридические реквизиты</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
везде здесь используем тайпографи
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
сделал
<div> | ||
<ul className={styles.contacts__adressPhone}> | ||
<li className={styles.contacts__text}>Телефон</li> | ||
<li>+7 977 848-02-28</li> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
телефон это, насколько я помню, link c типом tel
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
сделал
@@ -42,6 +43,8 @@ export const FeedbackPage = () => { | |||
dispatch(getFirstFeedbacks()) | |||
|
|||
dispatch(getAverageMark()) | |||
|
|||
scrollPageToTop() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
а как это работает, если мы кликаем на какой то определенный коммент на главной странице?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
сделал
Также: