-
-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GET product reviews request with an invalid value of param "size" the system returns all product reviews #328
Labels
Comments
TetianaPerinha
added
bug
Something isn't working
good first issue
Good for newcomers
labels
Jun 20, 2024
Hi @TetianaPerinha Please assign this bug to me and I will start working on this. |
Issue fixed in this PR. Please review |
@Sunagatov Review please |
Can you please review and approve the PR for merge. |
@TetianaPerinha / @Sunagatov Any update guys on this PR. It been hanging there for more than two months. Do you have any review comment ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
When sending a GET product reviews request with an invalid value of param "size" the system returns all product reviews
To Reproduce
Send the GET request as below use value for param size = %, +
curl --location '[https://iced-latte.uk/backend/api/v1/products/e6a4d7f2-d40e-4e5f-93b8-5d56ce6724c5/reviews?page={value}](https://iced-latte.uk/backend/api/v1/products/e6a4d7f2-d40e-4e5f-93b8-5d56ce6724c5/reviews?size={value}
Expected behavior
The system should reject the request with 400 HTTP Status code "error": "Bad Request".
Actual result
System accept the request and returns all product reviews.
The text was updated successfully, but these errors were encountered: