Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audio length determination fails for S3 as it does not set the base path #72

Open
FaeyUmbrea opened this issue Nov 19, 2023 · 0 comments

Comments

@FaeyUmbrea
Copy link

The code for custom asset indexing does not consider the source URL and the base path for S3 buckets when determining the length of the audio files, causing that part of the indexing process to fail with a lot of errors.

When the code arrives at this line: https://github.com/SvenWerlen/moulinette-core/blob/main/modules/moulinette-file-util.js#L1243C4-L1243C4
after iterating over an S3 bucket, none of the elements will have their full URL set, so the match fails, and the path is then constructed form the pack base path, which is just the directory relative to webroot, and the file name.

This causes the constructed path to be applied to the base path of the foundry installation, resulting in error.

I did not check if the same occurs on other parts of the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant