Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the User MVVM by removing user variable #98

Open
SaturneV opened this issue Nov 13, 2024 · 0 comments
Open

Refactor the User MVVM by removing user variable #98

SaturneV opened this issue Nov 13, 2024 · 0 comments
Labels
Refactor 🛠️ Code improvements without changing behavior

Comments

@SaturneV
Copy link
Contributor

SaturneV commented Nov 13, 2024

Description

In our current implementation, the difference between the _user and _currentUser variables in User MVVM makes almost no sense and complicates the integration of the viewmodel into our application. Given that the _user variable is not used and that our future integrations won't need it, it would be a good idea to refactor the viewmodel to use only the _currentUser variable in the viewmodel.

Tasks

  • Remove the _user variable from the User viewmodel.
  • Remove the related User viewmodel functions.
  • Adapt all the projects files that use the _user variable
  • Adapt all the projects tests files that use the _user variable
@SaturneV SaturneV added the Refactor 🛠️ Code improvements without changing behavior label Nov 13, 2024
@SaturneV SaturneV reopened this Dec 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Refactor 🛠️ Code improvements without changing behavior
Projects
None yet
Development

No branches or pull requests

2 participants