Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy course modal: Mandatory fields not highlighted #12653

Open
cedricongjh opened this issue Dec 11, 2023 · 20 comments · May be fixed by #13180
Open

Copy course modal: Mandatory fields not highlighted #12653

cedricongjh opened this issue Dec 11, 2023 · 20 comments · May be fixed by #13180
Labels
a-UIX User Interface, User eXperience, responsiveness good first issue Easy; restricted for first-time contributors p.VeryLow Just cosmetic value only. Do only if we have spare resources.

Comments

@cedricongjh
Copy link
Contributor

Description of feature/enhancement
When copying a course, user is not notified that the course ID and course name fields are mandatory:

image

Unlike when creating a course:
image

Let's make the behavior consistent between the 2, by displaying a red warning with an exclamation mark, stating "The field Course ID/Course Name should not be empty," when the instructor clicks the field but leaves it empty

@cedricongjh cedricongjh added a-UIX User Interface, User eXperience, responsiveness good first issue Easy; restricted for first-time contributors p.VeryLow Just cosmetic value only. Do only if we have spare resources. labels Dec 11, 2023
Copy link

Good First Issue - Notes for Contributors
This issue is for first-time contributors only. If you are new to TEAMMATES, feel free to submit a PR for this issue.

Please note that we allow only one good first issue per contributor. If you have already made a prior contribution to TEAMMATES, you may wish to take a look at issues with the help wanted tag instead.

We do not assign issues to contributors. If you would like to pick up this issue, do post a comment below to express your interest and check if there is anyone else who is already working on the issue. We will do our best to reply and give you the go-ahead, but if we don't, feel free to submit a PR as long as there is no one else working on it.

To get started, do read through our contributing guidelines carefully, and set up a development environment on your local machine before making a PR.

If you need any clarifications on our developer guide, or are facing issues that are not found in our troubleshooting guide, please post a message in our discussion forum.

@Valentinnin
Copy link

Valentinnin commented Dec 11, 2023

I will try to make that. aslong there is no new comment im on it (its my first try to make a contribution ever) Kind regards and Thanks 👍

Actually i think i could do that. but do you know how i do find specific code in such a huge directory?

@weiquu
Copy link
Contributor

weiquu commented Dec 12, 2023

Hi @Valentinnin, one of the methods I use is to first inspect the web page (e.g. using Chrome developer tools) and find the element that I want to change. Around that element, there should be a tag starting with tm-, which indicates the component that I'm looking for. From there, I go into my code editor and do a search for that component, and that usually brings up the relevant files.

Hope this helps! Do let us know if you run into any other issues

@SaiPreethamReddyy
Copy link

hey where can i find this page i am unable to find it ,please provide url of the page.

@cedricongjh
Copy link
Contributor Author

hi @SaiPreethamReddyy, to reach this page, you have to login as an instructor (follow the documentation for this: https://teammates.github.io/teammates/development.html)

Once logged in, navigate to courses (http://localhost:4200/web/instructor/courses), there should be an active course created, click on "other actions" and then "copy".

As a side note, we're letting @Valentinnin work on this as they have expressed interest first, @Valentinnin do let us know if you're still working on this, otherwise @SaiPreethamReddyy can take up this issue

@SaiPreethamReddyy
Copy link

image
i am unable to access the page

@weiquu
Copy link
Contributor

weiquu commented Dec 28, 2023

Hi @SaiPreethamReddyy, please make sure you have fully followed all the steps in the Setting Up and Development pages of the developer documentation. If you have done all that and are still unable to access the page, then do open a thread under Discussions so that we can help you troubleshoot further.

@SaiPreethamReddyy
Copy link

Front end site is working on my localhost4200 , now i want to login as instructor . How to do that ? I am unable to start backend server as my localhost8080 is working on another project .

@domlimm
Copy link
Contributor

domlimm commented Dec 30, 2023

@SaiPreethamReddyy Hello, you may update the port 8080 to 8081 in these files:
image

After updating those files, you should see 8081 in your terminal when you run ./gradlew serverRun.
image

Note that TEAMMATES backend development environment port defaults to 8080.

@Ganesh107
Copy link

can i work on this if it's still up for grab?

@dhiyanesh-cyber
Copy link

Hii @cedricongjh Can i work on this issue if it is still open for first time contributers ?

@cedricongjh
Copy link
Contributor Author

hi @Ganesh107 if you're still interested in working on this issue, do let us know here within 24 hours, otherwise @dhiyanesh-cyber feel free to take it up!

@Ganesh107
Copy link

Yes I’m interested

@Ganesh107
Copy link

hi @cedricongjh should I remove characters left message when error message is displayed
Screenshot (17)

@cedricongjh
Copy link
Contributor Author

hi @Ganesh107, let's keep the behaviour consistent as with #12617, and keep the charcters left message

@ArunErram
Copy link

is the issure still exists , can i work on it ?

@Josephine0110
Copy link

Can I work on this issue?

@nwroblewski
Copy link

I see that there is opened PR for this issue, could someone review it and close it so that it won't be hanging around? I am looking for an issue to work on and most of the issues with label good first issue are taken already :(

@AtharvaGurao
Copy link

Can I work on this issue?

@LeeY0846
Copy link

LeeY0846 commented Oct 3, 2024

Hi, can I try to work on this issue?

@XiangyuTan-learning
Copy link

Hi can I working on this as my first issue? since like there is no one taking it right now. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment