Set _CRT_SECURE_NO_WARNINGS in gsw_check_functions.c #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peter-urban
force-pushed
the
ignore_strcat_security_warnings_for_the_test_executable
branch
from
7fbd3ec
to
0063928
Compare
This ignores MSVC warnings about unsafe functions in the gsw_check_functions.c file (strcpy strncat strcat). While the security advice may be sound in the context of the main library, these functions are are not a security risk in the context of this test executable.
peter-urban
force-pushed
the
ignore_strcat_security_warnings_for_the_test_executable
branch
from
0063928
to
5ab356d
Compare
|
I agree with this strategy. Note that string concatenation in C is a bit of a mess, with |
efiring
approved these changes
Nov 12, 2024
|
Point of information to add to my previous comment: there are safe uses of strcat and |
peter-urban
deleted the
ignore_strcat_security_warnings_for_the_test_executable
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #77
Compiling on windows (with clang-cl or with msvc on a higher warning level) creates a number of these warnings
It would be possible with to replace the strcat, strncat and strcpy functions by strcat_s etc. However, these functions only appear in gsw_check_functions.c. And personally I don't think increasing memory safety / security is something to worry about in this test executable.
defining _CRT_SECURE_NO_WARNINGS ignores these msvc/windows specific "security" warnings. Since _CRT_SECURE_NO_WARNINGS is only defined in the gsw_check_functions.c, the warnings would still be displayed if these functions would be used within the main library.
If you disagree let me know, I can certainly ask co-pilot to show me how to replace strcat with strcat_s ;-)