Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multiple steps with same step-index are collated together within a single cycle #758

Open
ardunn opened this issue Feb 28, 2023 · 0 comments · May be fixed by #760
Open

multiple steps with same step-index are collated together within a single cycle #758

ardunn opened this issue Feb 28, 2023 · 0 comments · May be fixed by #760
Assignees
Labels
bug Something isn't working

Comments

@ardunn
Copy link
Collaborator

ardunn commented Feb 28, 2023

Due to the way steps are iterated in a cycle (pre- and post- #699), multiple steps can be collated together if there are distinct steps sharing the same step index (number). So if the step progression goes 1 $\rightarrow$ 2 $\rightarrow$ 1 $\rightarrow$ 5 and $1,000$ points are desired for each step, the first and third step will be collated together (if they are both detected as chg/dchg) resulting in a combined $1,000$ points rather than $1,000$ points each.

This can be fixed by adjusting the grouping in BEEPDatapath.iterate_steps_in_cycle and changing the groupby to include the step index counter (which must be present).

@ardunn ardunn added enhancement New feature or request bug Something isn't working and removed enhancement New feature or request labels Feb 28, 2023
@ardunn ardunn self-assigned this Feb 28, 2023
@ardunn ardunn linked a pull request Apr 23, 2023 that will close this issue
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant