Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Also translate dish type into English #253

Open
Friendly-Banana opened this issue Jul 25, 2024 · 3 comments · May be fixed by #260
Open

Also translate dish type into English #253

Friendly-Banana opened this issue Jul 25, 2024 · 3 comments · May be fixed by #260
Labels
enhancement New feature or request

Comments

@Friendly-Banana
Copy link

No description provided.

@COM8 COM8 added the enhancement New feature or request label Aug 8, 2024
@COM8
Copy link
Member

COM8 commented Aug 8, 2024

@Friendly-Banana sounds like a really good idea. Any chance you would like to work on a PR for it?

@Friendly-Banana
Copy link
Author

Yes, but I'm not so familiar with the codebase. How would I go about adding this?
There seem to be multiple partial DishType collections: FMIBistroMenuParser.DishType

dish_types: List[str] = []
dish_types = ["Veggie", "Traditionelle Küche", "Internationale Küche", "Specials"]
dish_types = re.split(r"\s{2,}", dish_types_line)

@COM8
Copy link
Member

COM8 commented Aug 17, 2024

Basically yes. There is not really more to it.

@Friendly-Banana Friendly-Banana linked a pull request Aug 25, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants