Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FluidTemplates page instructions #139

Closed
florinphp opened this issue Jul 27, 2023 · 1 comment · Fixed by #177
Closed

FluidTemplates page instructions #139

florinphp opened this issue Jul 27, 2023 · 1 comment · Fixed by #177

Comments

@florinphp
Copy link

florinphp commented Jul 27, 2023

There are some mistakes / misleading information in the Fluid Templates page as follows:

  1. At The website layout file section it is mentioned the following:
    Move the <f:render partial="Navigation/MainNavigation.html" arguments="{_all}"/> part from file Resources/Private/Templates/Page/Default.html ...
  • when searching for <f:render partial="Navigation/MainNavigation.html" arguments="{_all}"/> there are entries that it should be in various files but not this one mentioned in the quoted text.
  • it's mentioned wrongfully in the snipped here where the snippet should include the navigation html portion.
  1. At The page layout file it's mentioned Open file site_package/Resources/Private/Templates/Page/Default.html and then it's discussed we should delete some lines. Then it's indicated, that we could use the Jumbotron snippet inside that file. But both the file path and name indicated in the snipped below it's different than the path indicated above it.
  • site_package/Resources/Private/Templates/Page/Default.html
    VS
    EXT:site_package/Resources/Public/StaticTemplate/Step1Default.html
  1. There are 3 files mentioned Step1Default.html, Step2Default.html, Step3Default.html with common text that changes on each.
  • I believe the author was pointing out to the same file, Default.html but different versions;
  • this is very misleading for the reader, which will end up with 3 files created, just to realise that there should be just one.
  1. At the end of this page, there are no indication on how to use what we've created.
@linawolf
Copy link
Member

linawolf commented Oct 5, 2024

Hello @florinphp,

Thank you for your comment. I am sorry it took as such a long time to react. But we are few contributors and a large work load.

I agree that the section is in need of some overhaul. I know changed it while also switching to a bootstrap 5.3 template. Please check you issues are resolved with #177.

Greetings Lina - TYPO3 Documentation Team Leader

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants