Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: updated dependencies #200

Merged
merged 1 commit into from
Oct 11, 2024
Merged

feat: updated dependencies #200

merged 1 commit into from
Oct 11, 2024

Conversation

TeKrop
Copy link
Owner

@TeKrop TeKrop commented Oct 11, 2024

Summary by Sourcery

Update dependencies in pre-commit configuration and GitHub Actions workflow to newer versions.

Build:

  • Update pre-commit configuration to use ruff version v0.6.9 and sourcery version v1.23.0.

CI:

  • Update GitHub Actions workflow to use uv version 0.4.20.

@TeKrop TeKrop added the dependencies Pull requests that update a dependency file label Oct 11, 2024
@TeKrop TeKrop self-assigned this Oct 11, 2024
Copy link
Contributor

sourcery-ai bot commented Oct 11, 2024

Reviewer's Guide by Sourcery

This pull request updates the versions of development tools and dependencies used in the project. The changes focus on upgrading Ruff, Sourcery, and uv to their latest versions, which likely brings improvements in code linting, formatting, and build processes.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Upgrade Ruff pre-commit hook
  • Update Ruff version from v0.4.2 to v0.6.9
.pre-commit-config.yaml
Upgrade Sourcery pre-commit hook
  • Update Sourcery version from v1.16.0 to v1.23.0
.pre-commit-config.yaml
Update uv version in GitHub Actions workflow
  • Bump uv version from 0.4.10 to 0.4.20 in the build matrix
.github/workflows/build.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

sonarcloud bot commented Oct 11, 2024

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @TeKrop - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟡 General issues: 1 issue found
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@@ -14,7 +14,7 @@ jobs:
strategy:
matrix:
python-version: ["3.12"]
uv-version: ["0.4.10"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion (performance): Monitor build times after updating uv

The update to uv v0.4.20 might improve build times. Consider monitoring and comparing build times before and after this change to quantify any performance improvements.

     strategy:
       matrix:
         python-version: ["3.12"]
         uv-version: ["0.4.20"]
         include:
           - name: "Build Time"
             run: |
               echo "::set-output name=build_start::$(date +%s)"
               # Your build steps here
               echo "::set-output name=build_end::$(date +%s)"

@TeKrop TeKrop merged commit 96cd53e into main Oct 11, 2024
3 checks passed
@TeKrop TeKrop deleted the feature/dependencies-update branch October 11, 2024 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant