Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sidebar #88

Merged
merged 74 commits into from
Nov 19, 2024
Merged

Update sidebar #88

merged 74 commits into from
Nov 19, 2024

Conversation

duduBTW
Copy link
Collaborator

@duduBTW duduBTW commented Oct 19, 2024

A lot of UI updates.

  • Update sidebar to match the new Figma design.
  • Update song detail container design.
  • Update filters design.
  • Add support for multiple popovers opening one on top of another.
  • Add new roving focus group function.
  • Add new tabs component.
  • Update song item context menu to use the List component.
2024-10-31.23-33-31.mp4

@duduBTW duduBTW linked an issue Oct 19, 2024 that may be closed by this pull request
@D0m1nos D0m1nos mentioned this pull request Oct 24, 2024
@D0m1nos D0m1nos mentioned this pull request Nov 3, 2024
20 tasks
Copy link
Collaborator

@hrfarmer hrfarmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code and design of this looks good to me, however i strongly feel that the scale of the ui across the board needs to be scaled down, it looks like it's scaled 125% compared to nearly any other desktop app

i think this is a decent example, if you compare the scale of osu!radio at default zoom to zen
image

if i CMD + - osu!radio twice, i think it looks more reasonable
image

if people disagree then i'll let it go, but i really think it should be considered

@brw
Copy link
Member

brw commented Nov 19, 2024

I'm not opposed to scaling some stuff down but probably better to do that in a different PR afterwards

@hrfarmer
Copy link
Collaborator

I'm not opposed to scaling some stuff down but probably better to do that in a different PR afterwards

well i brought it up here since this pr is already touching like all of the ui code, but if you think it should be addressed in a different pr then that's fair

@brw
Copy link
Member

brw commented Nov 19, 2024

It's about time this gets merged and scaling stuff down is a pretty significant change to the overall design so that's better suited as a separate conversation I'd say

@hrfarmer
Copy link
Collaborator

It's about time this gets merged and scaling stuff down is a pretty significant change to the overall design so that's better suited as a separate conversation I'd say

fair

@brw brw requested a review from hrfarmer November 19, 2024 21:16
@duduBTW duduBTW merged commit 338033e into master Nov 19, 2024
5 checks passed
@duduBTW duduBTW deleted the feature/sidebar branch November 19, 2024 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New sidebar.
4 participants