-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update sidebar #88
Update sidebar #88
Conversation
…feature/sidebar
- Implement tab component on the main scene - Return tabindex on the roving focus group
- Add focus indicator to most elements - Add new input element
…feature/sidebar
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code and design of this looks good to me, however i strongly feel that the scale of the ui across the board needs to be scaled down, it looks like it's scaled 125% compared to nearly any other desktop app
i think this is a decent example, if you compare the scale of osu!radio at default zoom to zen
if i CMD + -
osu!radio twice, i think it looks more reasonable
if people disagree then i'll let it go, but i really think it should be considered
I'm not opposed to scaling some stuff down but probably better to do that in a different PR afterwards |
well i brought it up here since this pr is already touching like all of the ui code, but if you think it should be addressed in a different pr then that's fair |
It's about time this gets merged and scaling stuff down is a pretty significant change to the overall design so that's better suited as a separate conversation I'd say |
fair |
A lot of UI updates.
List
component.2024-10-31.23-33-31.mp4