From e9b51017b0c32cde576d30e47594d181682dde7c Mon Sep 17 00:00:00 2001 From: Kavin <20838718+FireMasterK@users.noreply.github.com> Date: Mon, 13 Mar 2023 00:17:58 +0000 Subject: [PATCH 1/5] Optimize HotSpot flags for performance. --- Dockerfile | 2 +- Dockerfile.ci | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Dockerfile b/Dockerfile index aa7be7ef..68b23f15 100644 --- a/Dockerfile +++ b/Dockerfile @@ -17,4 +17,4 @@ COPY VERSION . EXPOSE 8080 -CMD ["java", "--enable-preview", "-jar", "/app/piped.jar"] +CMD java -server -Xmx1G -XX:+AggressiveOpts -XX:+UnlockExperimentalVMOptions -XX:+UseStringCache -XX:+OptimizeStringConcat -XX:+UseStringDeduplication -XX:+UseCompressedOops -XX:+UseNUMA -XX:+UseG1GC -Xshare:on --enable-preview -jar /app/piped.jar diff --git a/Dockerfile.ci b/Dockerfile.ci index 20d2cb7c..ee5746f8 100644 --- a/Dockerfile.ci +++ b/Dockerfile.ci @@ -8,4 +8,4 @@ COPY VERSION . EXPOSE 8080 -CMD ["java", "--enable-preview", "-jar", "/app/piped.jar"] +CMD java -server -Xmx1G -XX:+AggressiveOpts -XX:+UnlockExperimentalVMOptions -XX:+UseStringCache -XX:+OptimizeStringConcat -XX:+UseStringDeduplication -XX:+UseCompressedOops -XX:+UseNUMA -XX:+UseG1GC -Xshare:on --enable-preview -jar /app/piped.jar From 2d88b349073a62cdf32dfade80e84f8974303f1f Mon Sep 17 00:00:00 2001 From: Kavin <20838718+FireMasterK@users.noreply.github.com> Date: Mon, 13 Mar 2023 00:18:43 +0000 Subject: [PATCH 2/5] Use hotspot as default image. Since the OpenJ9 builds crash randomly. --- .github/workflows/docker-build.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/docker-build.yml b/.github/workflows/docker-build.yml index fcaef6f9..ade53a4e 100644 --- a/.github/workflows/docker-build.yml +++ b/.github/workflows/docker-build.yml @@ -13,9 +13,9 @@ jobs: strategy: matrix: include: - - image: 1337kavin/piped:latest,1337kavin/piped:openj9 + - image: 1337kavin/piped:openj9 dockerfile: ./Dockerfile.openj9.ci - - image: 1337kavin/piped:hotspot + - image: 1337kavin/piped:latest,1337kavin/piped:hotspot dockerfile: ./Dockerfile.ci - image: 1337kavin/piped:graalvm-jvm dockerfile: ./Dockerfile.graalvm-jvm.ci From 141cf3189bab5feedc768ff445e3d3dc93885e2c Mon Sep 17 00:00:00 2001 From: Kavin <20838718+FireMasterK@users.noreply.github.com> Date: Mon, 13 Mar 2023 00:22:48 +0000 Subject: [PATCH 3/5] Remove -XX:+AggressiveOpts --- Dockerfile | 2 +- Dockerfile.ci | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Dockerfile b/Dockerfile index 68b23f15..74a32ce1 100644 --- a/Dockerfile +++ b/Dockerfile @@ -17,4 +17,4 @@ COPY VERSION . EXPOSE 8080 -CMD java -server -Xmx1G -XX:+AggressiveOpts -XX:+UnlockExperimentalVMOptions -XX:+UseStringCache -XX:+OptimizeStringConcat -XX:+UseStringDeduplication -XX:+UseCompressedOops -XX:+UseNUMA -XX:+UseG1GC -Xshare:on --enable-preview -jar /app/piped.jar +CMD java -server -Xmx1G -XX:+UnlockExperimentalVMOptions -XX:+UseStringCache -XX:+OptimizeStringConcat -XX:+UseStringDeduplication -XX:+UseCompressedOops -XX:+UseNUMA -XX:+UseG1GC -Xshare:on --enable-preview -jar /app/piped.jar diff --git a/Dockerfile.ci b/Dockerfile.ci index ee5746f8..88c67a7b 100644 --- a/Dockerfile.ci +++ b/Dockerfile.ci @@ -8,4 +8,4 @@ COPY VERSION . EXPOSE 8080 -CMD java -server -Xmx1G -XX:+AggressiveOpts -XX:+UnlockExperimentalVMOptions -XX:+UseStringCache -XX:+OptimizeStringConcat -XX:+UseStringDeduplication -XX:+UseCompressedOops -XX:+UseNUMA -XX:+UseG1GC -Xshare:on --enable-preview -jar /app/piped.jar +CMD java -server -Xmx1G -XX:+UnlockExperimentalVMOptions -XX:+UseStringCache -XX:+OptimizeStringConcat -XX:+UseStringDeduplication -XX:+UseCompressedOops -XX:+UseNUMA -XX:+UseG1GC -Xshare:on --enable-preview -jar /app/piped.jar From 92be1dfe02c6debb8514b5c479d571d388bdd30c Mon Sep 17 00:00:00 2001 From: Kavin <20838718+FireMasterK@users.noreply.github.com> Date: Mon, 13 Mar 2023 00:26:01 +0000 Subject: [PATCH 4/5] Remove -XX:+UseStringCache --- Dockerfile | 2 +- Dockerfile.ci | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Dockerfile b/Dockerfile index 74a32ce1..bba2bc50 100644 --- a/Dockerfile +++ b/Dockerfile @@ -17,4 +17,4 @@ COPY VERSION . EXPOSE 8080 -CMD java -server -Xmx1G -XX:+UnlockExperimentalVMOptions -XX:+UseStringCache -XX:+OptimizeStringConcat -XX:+UseStringDeduplication -XX:+UseCompressedOops -XX:+UseNUMA -XX:+UseG1GC -Xshare:on --enable-preview -jar /app/piped.jar +CMD java -server -Xmx1G -XX:+UnlockExperimentalVMOptions -XX:+OptimizeStringConcat -XX:+UseStringDeduplication -XX:+UseCompressedOops -XX:+UseNUMA -XX:+UseG1GC -Xshare:on --enable-preview -jar /app/piped.jar diff --git a/Dockerfile.ci b/Dockerfile.ci index 88c67a7b..281b9973 100644 --- a/Dockerfile.ci +++ b/Dockerfile.ci @@ -8,4 +8,4 @@ COPY VERSION . EXPOSE 8080 -CMD java -server -Xmx1G -XX:+UnlockExperimentalVMOptions -XX:+UseStringCache -XX:+OptimizeStringConcat -XX:+UseStringDeduplication -XX:+UseCompressedOops -XX:+UseNUMA -XX:+UseG1GC -Xshare:on --enable-preview -jar /app/piped.jar +CMD java -server -Xmx1G -XX:+UnlockExperimentalVMOptions -XX:+OptimizeStringConcat -XX:+UseStringDeduplication -XX:+UseCompressedOops -XX:+UseNUMA -XX:+UseG1GC -Xshare:on --enable-preview -jar /app/piped.jar From a8645f8623566772c3634cdaa9b147975359502c Mon Sep 17 00:00:00 2001 From: Kavin <20838718+FireMasterK@users.noreply.github.com> Date: Mon, 13 Mar 2023 00:27:54 +0000 Subject: [PATCH 5/5] Disable graalvm builds for now. --- .github/workflows/docker-build.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/docker-build.yml b/.github/workflows/docker-build.yml index ade53a4e..f1c69ef7 100644 --- a/.github/workflows/docker-build.yml +++ b/.github/workflows/docker-build.yml @@ -17,8 +17,8 @@ jobs: dockerfile: ./Dockerfile.openj9.ci - image: 1337kavin/piped:latest,1337kavin/piped:hotspot dockerfile: ./Dockerfile.ci - - image: 1337kavin/piped:graalvm-jvm - dockerfile: ./Dockerfile.graalvm-jvm.ci + # - image: 1337kavin/piped:graalvm-jvm + # dockerfile: ./Dockerfile.graalvm-jvm.ci steps: - uses: actions/checkout@v3 - name: Create Version File