From f00b9cafcd53af3e619ab7a7f17e324c1ad4fb31 Mon Sep 17 00:00:00 2001
From: Shiny Nematoda <snematoda.751k2@aleeas.com>
Date: Thu, 11 Jul 2024 17:59:42 +0000
Subject: [PATCH] feat: add option to favor hls over dash

---
 src/components/PreferencesPage.vue | 6 ++++++
 src/components/VideoPlayer.vue     | 7 ++++++-
 src/locales/en.json                | 3 ++-
 3 files changed, 14 insertions(+), 2 deletions(-)

diff --git a/src/components/PreferencesPage.vue b/src/components/PreferencesPage.vue
index 9259360dc5..eae7f63c56 100644
--- a/src/components/PreferencesPage.vue
+++ b/src/components/PreferencesPage.vue
@@ -69,6 +69,10 @@
         <strong v-t="'actions.audio_only'" />
         <input id="chkAudioOnly" v-model="listen" class="checkbox" type="checkbox" @change="onChange($event)" />
     </label>
+    <label class="pref" for="chkPreferHls">
+        <strong v-t="'actions.prefer_hls'" />
+        <input id="chkPreferHls" v-model="preferHls" class="checkbox" type="checkbox" @change="onChange($event)" />
+    </label>
     <label class="pref" for="ddlDefaultQuality">
         <strong v-t="'actions.default_quality'" />
         <select id="ddlDefaultQuality" v-model="defaultQuality" class="select w-auto" @change="onChange($event)">
@@ -438,6 +442,7 @@ export default {
             autoPlayNextCountdown: 5,
             listen: false,
             resolutions: [144, 240, 360, 480, 720, 1080, 1440, 2160, 4320],
+            preferHls: false,
             defaultQuality: 0,
             bufferingGoal: 10,
             countryMap: CountryMap,
@@ -619,6 +624,7 @@ export default {
                 localStorage.setItem("autoDisplayCaptions", this.autoDisplayCaptions);
                 localStorage.setItem("autoPlayNextCountdown", this.autoPlayNextCountdown);
                 localStorage.setItem("listen", this.listen);
+                localStorage.setItem("preferHls", this.preferHls);
                 localStorage.setItem("quality", this.defaultQuality);
                 localStorage.setItem("bufferGoal", this.bufferingGoal);
                 localStorage.setItem("region", this.countrySelected);
diff --git a/src/components/VideoPlayer.vue b/src/components/VideoPlayer.vue
index 55209febc3..40532eaad5 100644
--- a/src/components/VideoPlayer.vue
+++ b/src/components/VideoPlayer.vue
@@ -328,7 +328,12 @@ export default {
             if (this.video.livestream) {
                 uri = this.video.hls;
                 mime = "application/x-mpegURL";
-            } else if (this.video.audioStreams.length > 0 && !lbry && MseSupport) {
+            } else if (
+                this.video.audioStreams.length > 0 &&
+                !lbry &&
+                MseSupport &&
+                !this.getPreferenceBoolean("preferHls", false)
+            ) {
                 if (!this.video.dash) {
                     const dash = (await import("../utils/DashUtils.js")).generate_dash_file_from_formats(
                         streams,
diff --git a/src/locales/en.json b/src/locales/en.json
index 70b8c5cb8d..0ca4740097 100644
--- a/src/locales/en.json
+++ b/src/locales/en.json
@@ -160,7 +160,8 @@
         "creator_replied": "Creator replied",
         "creator_liked": "Creator liked",
         "playback_speed": "Playback speed",
-        "invalid_input": "Invalid input"
+        "invalid_input": "Invalid input",
+        "prefer_hls": "Prefer HLS over DASH"
     },
     "comment": {
         "pinned_by": "Pinned by {author}",