Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split library into server and client libraries #25

Closed
Tectu opened this issue Jun 25, 2021 · 5 comments
Closed

Split library into server and client libraries #25

Tectu opened this issue Jun 25, 2021 · 5 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@Tectu
Copy link
Owner

Tectu commented Jun 25, 2021

Currently, we build one library containing both server & client components (if enabled).
It might make sense to build separate libraries for the server components and the client components.

@Tectu Tectu added the enhancement New feature or request label Jun 25, 2021
@Tectu Tectu mentioned this issue Jun 28, 2021
@0x00002a
Copy link
Contributor

We also need to build a core library that they both link too. Can we use cmake to define targets like malloy::server, malloy::client, etc or is that only for find_package files?

@Tectu
Copy link
Owner Author

Tectu commented Jun 29, 2021

Yep, +1 for the core library.

I think what you do is just name the library targets core, client and server and then setup the namespace as malloy in the export configuration so consumers of the cmake lists (importing the library into another cmake project) will have them exposed as malloy::client etc.

@Tectu Tectu added this to the v0.1 milestone Jul 8, 2021
@0x00002a
Copy link
Contributor

0x00002a commented Jul 8, 2021

Working on this currently. Not sure if I should do the whole install stuff too since I think there is going to need to be some complex shenanigans with how server and client depend on core both with its internal name and in a transitive way for consumer projects

@Tectu
Copy link
Owner Author

Tectu commented Jul 8, 2021

I am working on this currently. 93% done 🤦

@Tectu Tectu self-assigned this Jul 8, 2021
@Tectu
Copy link
Owner Author

Tectu commented Jul 8, 2021

If you feel bored I certainly wouldn't mind if you'd tackle #40 :p
Hold your horses on a PR tho - the commit(s) for this task will restructure some stuff (mainly file locations).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants