Skip to content

Contributing

Brandon Frie edited this page Apr 15, 2020 · 9 revisions

Contributing

Issues

Issues are very valuable to this project.

  • Ideas are a valuable source of contributions others can make
  • Problems show where this project is lacking
  • With a question you show where contributors can improve the user experience

Thank you for creating them!

Pull Requests

Pull requests are a great way to get your ideas into this repository. When deciding if we merge in a pull request we look at the following things:

Does it state intent

You should be clear which problem you're trying to solve with your contribution.

For example:

Add link to code of conduct in README.md

Doesn't tell us anything about why you're doing that

Add link to code of conduct in README.md because users don't always look in the CONTRIBUTING.md

Tells us the problem that you have found and the pull request shows us the action you have taken to solve it.

Is it of good quality

  • There are no spelling mistakes
  • It reads well
  • For english language contributions: Has a good score on Grammarly or Hemingway App

Does it move this repository closer to our vision for the repository

The aim of this repository is to provide:

  • a highly-peformant, streaming data web API for Kerbal Space Program
  • a modern, javascript-based web user interface for displaying data from the API
  • a modern developer experience based around clean code principles and architectures

Does it follow the contributor covenant

This repository has a code of conduct, This repository has a code of conduct, I will remove things that do not respect it.

Attribution

This contribution guide was adapted from [PurpleBooth's template]https://gist.github.com/PurpleBooth/b24679402957c63ec426

Clone this wiki locally