Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GBVS360 with equatorial prior #7

Open
baharay opened this issue Jun 24, 2021 · 5 comments
Open

GBVS360 with equatorial prior #7

baharay opened this issue Jun 24, 2021 · 5 comments

Comments

@baharay
Copy link

baharay commented Jun 24, 2021

Hi,

Thank you very much for the nice work and making your models available.
I'm trying to use GBVS360 model with equatorial prior by using the command

salient.exe -i P10.jpg --general-model 2 -o saliency.jpg --legacy-icme-2017

as suggested here : https://github.com/Telecommunication-Telemedia-Assessment/GBVS360-BMS360-ProSal/releases/tag/2.0
However, it looks like the equatorial prior is not effective. When I add the argument for it and run the model with this command it seems fine :
salient.exe -i P10.jpg --general-model 2 -o saliency.jpg --legacy-icme-2017 --equatorial-prior

Here you can find an example image, the output of the first command, and the output of the second command :
cubemap_0000
cubemap_0000
cubemap_0000

Am I misusing the commands ? Or is there a typo in the given command ? I'd be very happy if you can point out what I am missing. Thanks in advance!

Best,
Bahar

@plebreton
Copy link
Collaborator

Hi,

Thank you for raising this issue. I checked it, and I can confirm that the equatorial prior is not applied...
I will fix it and upload a new build, as indeed it is not what I would have expected...

Thank a lot for pointing it out

I will spend time on that later today/tomorrow morning.

@baharay
Copy link
Author

baharay commented Jul 12, 2021

Hi,

Thank you for the confirmation! We're looking forward to the new release. In the meantime, can we test your models (from the release on 19 Oct 2018) with the following commands to see the effect of the equatorial prior? For example;

BMS360
.\salient.exe -i .\test.jpg -o .\saliency.jpg --general-model 1

BMS360 with equatorial prior
.\salient.exe -i .\test.jpg -o .\saliency.jpg --general-model 1 --equatorial-prior

If so, can we also use this argument for the BMS and GBVS360 models?

@plebreton
Copy link
Collaborator

Hello,

Sorry for the late reply. I now updated the release. You can find it under the name "model-latest.7z".
I recompiled it with a new version of visual studio, and I also updated the OpenCV version. Let me know if you encounter any issues.

Regarding the usage of the release from Oct 19 2018, you are correct.

With that build, you can access the other model like this:

BMS
.\salient.exe -i .\test.jpg -o .\saliency.jpg --general-model 1 --legacy-icme-2017

BMS with equatorial prior
.\salient.exe -i .\test.jpg -o .\saliency.jpg --general-model 1 --legacy-icme-2017 --equatorial-prior

GBVS360
.\salient.exe -i .\test.jpg -o .\saliency.jpg --general-model 2 --legacy-icme-2017

GBVS360 with equatorial prior
.\salient.exe -i .\test.jpg -o .\saliency.jpg --general-model 2 --legacy-icme-2017 --equatorial-prior

@baharay
Copy link
Author

baharay commented Jul 29, 2021

Hi,

Thank you for the explanations. I'm sorry to bother you again but I couldn't find "model-latest.7z". Could you please provide a link? Lastly, can we use the same commands above for the new release?

@plebreton
Copy link
Collaborator

plebreton commented Jul 30, 2021

Hi,

No problem. You can find the release there:
https://github.com/Telecommunication-Telemedia-Assessment/GBVS360-BMS360-ProSal/releases/tag/2.0

With this version, you won't have the control over the use of the equatorial prior (eg. the option --equatorial-prior is not available). But you can choose among the different models as listed in the instruction of tha page linked above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants