Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat:support consul config. #1394

Merged
merged 3 commits into from
Aug 19, 2024

Conversation

fuyuwei01
Copy link
Contributor

PR Type

Describe what this PR does for and how you did.

Adding the issue link (#xxx) if possible.

Note

Checklist

  • Add information of this PR to CHANGELOG.md in root of project.
  • Add documentation in javadoc or comment below the PR if necessary.

Checklist (Optional)

  • Will pull request to branch of 2023.
  • Will pull request to branch of 2022.
  • Will pull request to branch of 2021.
  • Will pull request to branch of 2020.
  • Will pull request to branch of hoxton.

Copy link

codecov bot commented Aug 19, 2024

Codecov Report

Attention: Patch coverage is 16.66667% with 80 lines in your changes missing coverage. Please review.

Project coverage is 65.35%. Comparing base (f92d885) to head (dbed91d).
Report is 1 commits behind head on 2020.

Files Patch % Lines
...d/polaris/config/tsf/TsfConfigurationModifier.java 0.00% 18 Missing ⚠️
...stry/TsfMetadataPolarisRegistrationCustomizer.java 0.00% 11 Missing ⚠️
...java/com/tencent/cloud/common/tsf/TsfConstant.java 0.00% 9 Missing ⚠️
.../polaris/context/tsf/config/TsfCoreProperties.java 0.00% 9 Missing ⚠️
...nt/cloud/polaris/config/ConfigurationModifier.java 20.00% 6 Missing and 2 partials ⚠️
.../cloud/polaris/tsf/TsfDiscoveryConfigModifier.java 0.00% 5 Missing ⚠️
...loud/polaris/context/PolarisSDKContextManager.java 54.54% 5 Missing ⚠️
...olaris/context/tsf/consul/TsfConsulProperties.java 0.00% 4 Missing ⚠️
...laris/config/adapter/PolarisConfigFileLocator.java 66.66% 0 Missing and 3 partials ⚠️
...t/cloud/polaris/config/config/ConfigFileGroup.java 25.00% 3 Missing ⚠️
... and 3 more
Additional details and impacted files
@@             Coverage Diff              @@
##               2020    #1394      +/-   ##
============================================
- Coverage     65.60%   65.35%   -0.25%     
  Complexity        2        2              
============================================
  Files           315      316       +1     
  Lines          7269     7309      +40     
  Branches        877      881       +4     
============================================
+ Hits           4769     4777       +8     
- Misses         2100     2130      +30     
- Partials        400      402       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SkyeBeFreeman SkyeBeFreeman added this to the 2.0.0.0 milestone Aug 19, 2024
@SkyeBeFreeman SkyeBeFreeman merged commit ace4ecb into Tencent:2020 Aug 19, 2024
8 of 9 checks passed
@fuyuwei01 fuyuwei01 deleted the 2020-conful-config444 branch August 27, 2024 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants