Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AssertionRoulette] Handle Assertj's methods Descriptable.as and AbstractAssert.withFailMessage #13

Open
victorgveloso opened this issue Jun 25, 2021 · 0 comments

Comments

@victorgveloso
Copy link

As discussed in a stackoverflow question. AssertJ's assertions differ from builtin Junit's assertions as they don't have third or second parameters for descriptions. Instead, they offer the Descriptable.as and AbstractAssert.withFailMessage methods.

On the other hand, TSDetect's AssertionRoulette implementation ( at /src/main/java/testsmell/smell/AssertionRoulette.java) handles an homonymous assertion from Junit 4 (assertThat) which is deprecated. For projects using AssertJ, this could raise the false impression that test methods using Descriptable.as or AbstractAssert.withFailMessage are description-less.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant