-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shorten SubDirectory
to SubDir
#47
Comments
Hi. I cannot remember the tought process to come up with the SubDirectory name at the time. I think it was to align with the general API naming conventions in the parent library. |
I assumed having both would just make the interface confusing and I wouldn't want that for your code base. If nothing else, I'm happy keeping the extension methods I already have that essentially just rename the method. I recently upgraded the nuget package which introduced some new signatures, which meant I had to update my extensions, which is what led me to think of this and file the report. I realize my request is subjective and not all that important. If you're happy with how it is, that's fine too. I really appreciate you responding and being open minded about it. |
The And now that I write it I notice the small inconsistency between Maybe |
I realize for backward compatibility, we can't just flat-out rename it. I feel like
SubDirectory
is a bit of a mouthful and not very concise. How would you feel about deprecating that in favor of methods namedSubDir
with equivalent signatures and overloads?If you're OK with it, I'm happy to do the work. I just want to see if my request has merit before I spend time on it.
The text was updated successfully, but these errors were encountered: