Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make plugin compatible with Matomo 4 #44

Open
Findus23 opened this issue Sep 1, 2020 · 5 comments
Open

Make plugin compatible with Matomo 4 #44

Findus23 opened this issue Sep 1, 2020 · 5 comments

Comments

@Findus23
Copy link

Findus23 commented Sep 1, 2020

Hi, hope you are doing well!

Matomo 4 is progressing steadily and it would be great if this plugin was also available for it.

Migrating the plugin should be pretty simple as there were not many breaking changes.

You can find the migration guide here: https://developer.matomo.org/guides/migrate-matomo-3-to-4

It boils down to:

  • update your dev environment to 4.x-dev
  • update your plugin.json (new major version of the plugin and require >=4.0.0-b1,<5.0.0-b1)
  • check that everything still works fine
  • commit this to a new branch (e.g. 4.x-dev) and make this branch the default in the github settings
  • tag and push a new release to publish it to the marketplace

If you later fix a bug and also want to backport it to the 3.x plugin, you can cherry-pick the commit to the old branch, release a new version (lower than the one for 4.x) and publish it and 3.x users should get this update.

If you have questions about anything, just ask me!

@bbodenmiller
Copy link

@ThaDafinser any chance this will be updated to support Matomo 4?

@Findus23
Copy link
Author

At least according to herveh35@ae9b535 it seems like just changing the supported version range should be enough to get it to work in Matomo 4.

A reminder for everyone reading this: This plugin is licensed under the MIT license, so everyone is free to fork it and take up maintaining it as long as they follow the license.

@tunetheweb
Copy link

Can confirm manually applying herveh35@ae9b535 allowed me to activate the plugin and it seems to be working fine under 4.2.1.

@plegault3397
Copy link

plegault3397 commented Apr 21, 2021

I tried and everything stopped working, not recording site visits for any of the sites being monitored. I needed to disable it

@plegault3397
Copy link

OK My bad,
I looked again and it seems to be working . Maybe there was something else going with another issue I was having

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants