Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firefox: Adding subtitle before playback throw an error of Offset renderer #31

Open
zoriya opened this issue Oct 14, 2023 · 1 comment

Comments

@zoriya
Copy link
Contributor

zoriya commented Oct 14, 2023

When the offset renderer is enabled, and you run new Jassub(...) with a video that as not started playing, this error is thrown:

Uncaught DOMException: OffscreenCanvas.width setter: Cannot set width of placeholder canvas transferred to worker.
    _render jassub.js:681
    _onmessage jassub.js:783
    onmessage jassub.js:120
    JASSUB jassub.js:120

This is my new call:

new Jassub({
	video: player.current,
	workerUrl: "/_next/static/chunks/jassub-worker.js",
	wasmUrl: "/_next/static/chunks/jassub-worker.wasm",
	legacyWasmUrl: "/_next/static/chunks/jassub-worker.wasm.js",
	subUrl: value.link,
	fonts: fonts,
});

(Since September 2023, OffscreenCanvas is stable in FF, so this is not like #10)

@ThaUnknown
Copy link
Owner

just firefox things, feel free to disable offscreen canvas in ff, i cba fixing this for firefox for the 5th time, they simply can't implement it properly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants