Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: remove accessories as embedded library #2376

Closed
3 tasks done
VaporeonScripts opened this issue Nov 14, 2024 · 1 comment
Closed
3 tasks done

Feature Request: remove accessories as embedded library #2376

VaporeonScripts opened this issue Nov 14, 2024 · 1 comment
Labels
type/request The issue is a feature or change request and does not fit into the other types.

Comments

@VaporeonScripts
Copy link

What Feature Types Apply to This Request?

Other (Please Describe)

Other Type

remove dependency as not not needed

Is This an Enhancement to a Preexisting Feature?

  • I confirm this request is an enhancement to a feature already in The Aether.

What Is Your Feature Request?

remove accessories embedded dependency, as most people dont use it/got curios continuation

Why Should It Be in the Mod?

should be removed

Does This Feature Improve Compatibility With Another Mod?

well kinda

Please Read and Confirm the Following

  • I have confirmed this feature is either in the original Aether mod, or improves parity between The Aether and Minecraft or other mods.
  • I have confirmed this suggestion is unique and has not been suggested already.
@VaporeonScripts VaporeonScripts added the type/request The issue is a feature or change request and does not fit into the other types. label Nov 14, 2024
@github-project-automation github-project-automation bot moved this to Back Log in The Aether Nov 14, 2024
@bconlon1
Copy link
Contributor

The dependency isn't "not needed" since it is what our accessories implementation currently depends on, it can't just be removed on its own. The Accessories API was used since it makes the handling of our Fabric port's development alongside the NeoForge version much smoother, and the API should still be compatible with other mods especially if they've maintained Curios' data-driven customization for managing slots. The API was also used before a reliable Curios successor popped up, although that whole situation has at least given me concerns about future-proofing in the vein of this request, as detailed in #2194, since while I don't expect Accessories API to disappear any time soon I would like to have the mod be prepared for anything (this however is still quite low priority compared to other develpment tasks).

@bconlon1 bconlon1 closed this as not planned Won't fix, can't repro, duplicate, stale Nov 14, 2024
@github-project-automation github-project-automation bot moved this from Back Log to Done in The Aether Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/request The issue is a feature or change request and does not fit into the other types.
Projects
Status: Done
Development

No branches or pull requests

2 participants