From 230828f02fe1911ed2e8cc614d2c62263bbfe34a Mon Sep 17 00:00:00 2001 From: NickChecan Date: Fri, 18 Oct 2024 03:57:53 +0000 Subject: [PATCH 1/4] fix: make sure github actions bot have permissions for semantic release --- .github/workflows/release.yaml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.github/workflows/release.yaml b/.github/workflows/release.yaml index da41b2c..c3480ef 100644 --- a/.github/workflows/release.yaml +++ b/.github/workflows/release.yaml @@ -5,6 +5,9 @@ on: branches: - main +permissions: + contents: write # Ensure the GitHub Actions bot has write access + jobs: deploy: if: ${{ github.ref == 'refs/heads/main' }} From 7e7c6dc42ba23cd5a37087673d8ba8a304378369 Mon Sep 17 00:00:00 2001 From: NickChecan Date: Fri, 18 Oct 2024 04:13:05 +0000 Subject: [PATCH 2/4] fix: set namespace for the template instead of using the repo name --- .github/workflows/release.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/release.yaml b/.github/workflows/release.yaml index c3480ef..6708cac 100644 --- a/.github/workflows/release.yaml +++ b/.github/workflows/release.yaml @@ -21,6 +21,7 @@ jobs: - name: "Publish" uses: devcontainers/action@v1 with: + templates-namespace: "devcontainer" publish-templates: "true" base-path-to-templates: "./src" env: From 3a2a198afe207219ffe6e1394e1424a0dc85ee8b Mon Sep 17 00:00:00 2001 From: NickChecan Date: Fri, 18 Oct 2024 04:18:30 +0000 Subject: [PATCH 3/4] refactor: change namespace from devcontainer to devcontainers --- .github/workflows/release.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/release.yaml b/.github/workflows/release.yaml index 6708cac..7a7325d 100644 --- a/.github/workflows/release.yaml +++ b/.github/workflows/release.yaml @@ -21,7 +21,7 @@ jobs: - name: "Publish" uses: devcontainers/action@v1 with: - templates-namespace: "devcontainer" + templates-namespace: "devcontainers" publish-templates: "true" base-path-to-templates: "./src" env: From 7d06487201870709ff377c69f7dcf89114ff4581 Mon Sep 17 00:00:00 2001 From: NickChecan Date: Fri, 18 Oct 2024 04:29:58 +0000 Subject: [PATCH 4/4] fix: simplify the template description --- src/sap-cap-javascript-node/devcontainer-template.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/sap-cap-javascript-node/devcontainer-template.json b/src/sap-cap-javascript-node/devcontainer-template.json index f1ef7a4..1b8d455 100644 --- a/src/sap-cap-javascript-node/devcontainer-template.json +++ b/src/sap-cap-javascript-node/devcontainer-template.json @@ -2,7 +2,7 @@ "id": "sap-cap-javascript-node", "version": "1.0.0", "name": "SAP CAP", - "description": "Develop CAP based projects for the SAP BTP Cloud Foundry runtime.", + "description": "Develop CAP based projects for SAP BTP Cloud Foundry.", "documentationURL": "https://github.com/The-Nefarious-Developer/devcontainer-templates/tree/main/src/sap-cap-javascript-node", "publisher": "The Nefarious Developer", "licenseURL": "https://github.com/The-Nefarious-Developer/devcontainer-templates/blob/main/LICENSE",