[WARNING STA-0139] ... 63.3687 is not a float. #3314

oharboe · 2023-05-10T05:39:19Z

oharboe
May 10, 2023
Collaborator

I get a lot of these warnings when I run make gui_final

This is with the latest ORFS.

What are they?

$ make DESIGN_CONFIG=designs/asap7/mock-array-big/Element/config.mk place

[WARNING STA-0139] /home/oyvind/OpenROAD-flow-scripts/flow/platforms/asap7/lib/asap7sc7p5t_AO_RVT_TT_nldm_211120.lib.gz line 397, 63.3687 is not a float.
[WARNING STA-0139] /home/oyvind/OpenROAD-flow-scripts/flow/platforms/asap7/lib/asap7sc7p5t_AO_RVT_TT_nldm_211120.lib.gz line 397, 79.0805 is not a float.
[WARNING STA-0139] /home/oyvind/OpenROAD-flow-scripts/flow/platforms/asap7/lib/asap7sc7p5t_AO_RVT_TT_nldm_211120.lib.gz line 397, 106.935 is not a float.
[WARNING STA-0139] /home/oyvind/OpenROAD-flow-scripts/flow/platforms/asap7/lib/asap7sc7p5t_AO_RVT_TT_nldm_211120.lib.gz line 397, 156.622 is not a float.
[WARNING STA-0139] /home/oyvind/OpenROAD-flow-scripts/flow/platforms/asap7/lib/asap7sc7p5t_AO_RVT_TT_nldm_211120.lib.gz line 397, 248.596 is not a float.
[WARNING STA-0139] /home/oyvind/OpenROAD-flow-scripts/flow/platforms/asap7/lib/asap7sc7p5t_AO_RVT_TT_nldm_211120.lib.gz line 397, 432.982 is not a float.
[WARNING STA-0139] /home/oyvind/OpenROAD-flow-scripts/flow/platforms/asap7/lib/asap7sc7p5t_AO_RVT_TT_nldm_211120.lib.gz line 406, 0.36 is not a float.
[WARNING STA-0139] /home/oyvind/OpenROAD-flow-scripts/flow/platforms/asap7/lib/asap7sc7p5t_AO_RVT_TT_nldm_211120.lib.gz line 406, 0.72 is not a float.
[WARNING STA-0139] /home/oyvind/OpenROAD-flow-scripts/flow/platforms/asap7/lib/asap7sc7p5t_AO_RVT_TT_nldm_211120.lib.gz line 406, 1.44 is not a float.
[WARNING STA-0139] /home/oyvind/OpenROAD-flow-scripts/flow/platforms/asap7/lib/asap7sc7p5t_AO_RVT_TT_nldm_211120.lib.gz line 406, 2.88 is not a float.
[WARNING STA-0139] /home/oyvind/OpenROAD-flow-scripts/flow/platforms/asap7/lib/asap7sc7p5t_AO_RVT_TT_nldm_211120.lib.gz line 406, 5.76 is not a float.
[WARNING STA-0139] /home/oyvind/OpenROAD-flow-scripts/flow/platforms/asap7/lib/asap7sc7p5t_AO_RVT_TT_nldm_211120.lib.gz line 406, 11.52 is not a float.
[WARNING STA-0139] /home/oyvind/OpenROAD-flow-scripts/flow/platforms/asap7/lib/asap7sc7p5t_AO_RVT_TT_nldm_211120.lib.gz line 406, 23.04 is not a float.
[WARNING STA-0139] /home/oyvind/OpenROAD-flow-scripts/flow/platforms/asap7/lib/asap7sc7p5t_AO_RVT_TT_nldm_211120.lib.gz line 415, 12.8576 is not a float.
[WARNING STA-0139] /home/oyvind/OpenROAD-flow-scripts/flow/platforms/asap7/lib/asap7sc7p5t_AO_RVT_TT_nldm_211120.lib.gz line 415, 15.7364 is not a float.
[WARNING STA-0139] /home/oyvind/OpenROAD-flow-scripts/flow/platforms/asap7/lib/asap7sc7p5t_AO_RVT_TT_nldm_211120.lib.gz line 415, 21.3969 is not a float.
[WARNING STA-0139] /home/oyvind/OpenROAD-flow-scripts/flow/platforms/asap7/lib/asap7sc7p5t_AO_RVT_TT_nldm_211120.lib.gz line 415, 32.5931 is not a float.

vijayank88 · 2023-05-11T07:20:10Z

vijayank88
May 11, 2023
Collaborator

@oharboe
I ran with latest commit and not able to get similar logs.

0 replies

maliberty · 2023-05-11T16:26:42Z

maliberty
May 11, 2023
Maintainer

The report says 'make place' and 'make gui_final' which are not a compatible pair. I can't reproduce this either even running all the way through.

0 replies

oharboe · 2023-05-12T09:16:10Z

oharboe
May 12, 2023
Collaborator Author

rm -rf results/
make DESIGN_CONFIG=designs/asap7/mock-array-big/Element/config.mk place
make DESIGN_CONFIG=designs/asap7/mock-array-big/Element/config.mk gui_place

$ make DESIGN_CONFIG=designs/asap7/mock-array-big/Element/config.mk gui_place
[INFO][FLOW] Using platform directory ./platforms/asap7
[INFO-FLOW] ASU ASAP7 - version 2
Default PVT selection: BC
ODB_FILE=./results/asap7/mock-array-big_Element/base/3_place.odb /home/oyvind/OpenROAD-flow-scripts/tools/install/OpenROAD/bin/openroad -gui  ./scripts/gui.tcl
Warning: Ignoring XDG_SESSION_TYPE=wayland on Gnome. Use QT_QPA_PLATFORM=wayland to run on Wayland anyway.
This plugin does not support propagateSizeHints()
OpenROAD v2.0-8114-gaa1f8060d 
This program is licensed under the BSD-3 license. See the LICENSE file for details.
Components of this program may be licensed under more restrictive licenses which must be honored.
[WARNING STA-0139] ./platforms/asap7/lib/asap7sc7p5t_AO_RVT_FF_nldm_211120.lib.gz line 82, 0.72 is not a float.
[WARNING STA-0139] ./platforms/asap7/lib/asap7sc7p5t_AO_RVT_FF_nldm_211120.lib.gz line 82, 1.44 is not a float.
[WARNING STA-0139] ./platforms/asap7/lib/asap7sc7p5t_AO_RVT_FF_nldm_211120.lib.gz line 82, 2.88 is not a float.
[WARNING STA-0139] ./platforms/asap7/lib/asap7sc7p5t_AO_RVT_FF_nldm_211120.lib.gz line 82, 5.76 is not a float.
[WARNING STA-0139] ./platforms/asap7/lib/asap7sc7p5t_AO_RVT_FF_nldm_211120.lib.gz line 82, 11.52 is not a float.
[WARNING STA-0139] ./platforms/asap7/lib/asap7sc7p5t_AO_RVT_FF_nldm_211120.lib.gz line 82, 23.04 is not a float.
[WARNING STA-0139] ./platforms/asap7/lib/asap7sc7p5t_AO_RVT_FF_nldm_211120.lib.gz line 82, 46.08 is not a float.
[WARNING STA-0139] ./platforms/asap7/lib/asap7sc7p5t_AO_RVT_FF_nldm_211120.lib.gz line 96, 0.72 is not a float.
[WARNING STA-0139] ./platforms/asap7/lib/asap7sc7p5t_AO_RVT_FF_nldm_211120.lib.gz line 96, 1.44 is not a float.
[WARNING STA-0139] ./platforms/asap7/lib/asap7sc7p5t_AO_RVT_FF_nldm_211120.lib.gz line 96, 2.88 is not a float.
[WARNING STA-0139] ./platforms/asap7/lib/asap7sc7p5t_AO_RVT_FF_nldm_211120.lib.gz line 96, 5.76 is not a float.

2 replies

vijayank88 May 12, 2023
Collaborator

@oharboe
You're trying to forcefully remove all results directory. It lost all previous stage results.
How you're able to run place stage directly?

oharboe May 12, 2023
Collaborator Author

make place will work from a full clean and create all its dependencies, but make gui_final requires everything to built.

oharboe · 2023-05-17T17:03:22Z

oharboe
May 17, 2023
Collaborator Author

@maliberty Aha! This is a locale issue. In their wisdom a hundred years ago, Norwegians decided to use "," to separate integers from fractions in floating point... So "12.34" is not a valid float in Norwegian locale, rather "12,34" is.

The evidence that this is the problem is that setting LC_NUMERIC="en_GB.UTF-8" fixes the problem.

In this case, the locale is decided by the format that is being parsed, it is not a human readable/writeable number.

Let's see if this works: https://github.com/Pinata-Consulting/OpenSTA/tree/lock-down-strtof-locale

Yep :-)

This also explains why we don't see this when we run from docker, only local install.

0 replies

maliberty · 2023-05-17T17:47:34Z

maliberty
May 17, 2023
Maintainer

Brazil has the same issue.

OpenROAD/src/Main.cc

Line 217 in 6920ac5

std::array locales = {"en_US.UTF-8", "C.UTF-8", "C"};

attempts to solve this. Do none of the locales exist on your systems?

12 replies

oharboe May 17, 2023
Collaborator Author

Hmmm... setlocale() is probably called to read the current locale.

By the time it is in liberty parsing, the locale is still what it was set to.

oharboe May 17, 2023
Collaborator Author

So the locale is set, but the result from strtof() still parses "Norwegian" numbers...

Some more experiments:

Console is in 'commands' mode, prefix expressions with '?'.
Attached to process 301940
expr (char*) setlocale(0, NULL)
(char *) $0 = 0x000055f26e47b610 "en_US.UTF-8"
expr (float) strtof("234.1234", NULL)
(float) $1 =

 234
expr (float) strtof("234,1234", NULL)

(float) $2 = 234.123398
call setlocale(6, "C")
(char *) $3 =

 0x00007f0acdfb75ff "C"
expr (float) strtof("234.1234", NULL)
(float) $4 = 234.123398

call setlocale(6, "C")
(char *) $5 = 0x00007f0acdfb75ff "C"

expr (float) strtof("234.1234", NULL)
(float)

$6 = 234.123398
call setlocale(6, "en_US.UTF-8")
(char *) $7 =

 0x000055f26e4e9730 "en_US.UTF-8"
expr (float) strtof("234.1234", NULL)
(float) $8 =

 234.123398

So.... that's weird...

oharboe May 17, 2023
Collaborator Author

maliberty · 2023-05-17T20:34:20Z

maliberty
May 17, 2023
Maintainer

Would you try your strtof check along with getlocale after these various points to try to see what's going on. I think this works in Brazil so I'm trying to understand what's different here. @luis201420 any insights?

2 replies

luis201420 May 17, 2023
Collaborator

I have this error when I execute with GUI activated, to solve it I add these lines to set LC_ALL in the first part of tclAppInit function in Main.cc

std::array locales = {"en_US.UTF-8", "C.UTF-8", "C"};
  for (auto locale : locales) {
    if (std::setlocale(LC_ALL, locale) != nullptr) {
      break;
    }
}

I found that in the main function LC_ALL is set but after calling the Tcl_Main function again it is reset

oharboe May 17, 2023
Collaborator Author

I see the same thing... setlocal() is called perhaps once per major framework? Qt, Tcl, Python, etc.... Everybody wants to help out...

maliberty · 2023-05-17T20:36:26Z

maliberty
May 17, 2023
Maintainer

Perhaps it relates to LC_NUMERIC or another. Can you try unsetting all LC_* but LC_ALL in your environment to see if that matters?

2 replies

oharboe May 17, 2023
Collaborator Author

LC_ALL is not set.

maliberty May 17, 2023
Maintainer

In the c++ code try setting all the locale variables rather than just LC_ALL and see if that helps.

oharboe · 2023-05-17T21:13:00Z

oharboe
May 17, 2023
Collaborator Author

@maliberty @luis201420 With this change, I no longer get the warnings.

This is just a quick hack, I think it would be better if someone who knows what is going on and are aware of other edgecases articulates the pull request :-)

diff --git a/src/gui/src/gui.cpp b/src/gui/src/gui.cpp
index 355aa6842..7d79d99a3 100644
--- a/src/gui/src/gui.cpp
+++ b/src/gui/src/gui.cpp
@@ -1141,6 +1141,16 @@ int startGui(int& argc,
   }
   main_window->show();
 
+  // This avoids problems with locale setting dependent
+  // C functions like strtod (e.g. 0.5 vs 0,5).
+  std::array locales = {"en_US.UTF-8", "C.UTF-8", "C"};
+  for (auto locale : locales) {
+    if (std::setlocale(LC_ALL, locale) != nullptr) {
+      break;
+    }
+  }
+
+
   gui->setLogger(open_road->getLogger());
 
   main_window->setDatabase(open_road->getDb());

0 replies

maliberty · 2023-05-18T05:25:42Z

maliberty
May 18, 2023
Maintainer

@luis201420 will you look at this since you can reproduce it

0 replies

oharboe · 2023-05-18T06:50:33Z

oharboe
May 18, 2023
Collaborator Author

I guess this has been identified as a bug in OpenROAD, given that there are frameworks that set the locale after OpenROAD has set the locale.

0 replies

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[WARNING STA-0139] ... 63.3687 is not a float. #3314

{{title}}

{{editor}}'s edit

{{editor}}'s edit

Replies: 10 comments 18 replies

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{editor}}'s edit

{{editor}}'s edit

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

Select a reply

[WARNING STA-0139] ... 63.3687 is not a float. #3314

oharboe May 10, 2023 Collaborator

Replies: 10 comments · 18 replies

vijayank88 May 11, 2023 Collaborator

maliberty May 11, 2023 Maintainer

oharboe May 12, 2023 Collaborator Author

vijayank88 May 12, 2023 Collaborator

oharboe May 12, 2023 Collaborator Author

oharboe May 17, 2023 Collaborator Author

maliberty May 17, 2023 Maintainer

oharboe May 17, 2023 Collaborator Author

oharboe May 17, 2023 Collaborator Author

oharboe May 17, 2023 Collaborator Author

oharboe May 17, 2023 Collaborator Author

oharboe May 17, 2023 Collaborator Author

maliberty May 17, 2023 Maintainer

luis201420 May 17, 2023 Collaborator

oharboe May 17, 2023 Collaborator Author

maliberty May 17, 2023 Maintainer

oharboe May 17, 2023 Collaborator Author

maliberty May 17, 2023 Maintainer

oharboe May 17, 2023 Collaborator Author

maliberty May 18, 2023 Maintainer

oharboe May 18, 2023 Collaborator Author

oharboe
May 10, 2023
Collaborator

Replies: 10 comments 18 replies

vijayank88
May 11, 2023
Collaborator

maliberty
May 11, 2023
Maintainer

oharboe
May 12, 2023
Collaborator Author

vijayank88 May 12, 2023
Collaborator

oharboe May 12, 2023
Collaborator Author

oharboe
May 17, 2023
Collaborator Author

maliberty
May 17, 2023
Maintainer

oharboe May 17, 2023
Collaborator Author

oharboe May 17, 2023
Collaborator Author

oharboe May 17, 2023
Collaborator Author

oharboe May 17, 2023
Collaborator Author

oharboe May 17, 2023
Collaborator Author

maliberty
May 17, 2023
Maintainer

luis201420 May 17, 2023
Collaborator

oharboe May 17, 2023
Collaborator Author

maliberty
May 17, 2023
Maintainer

oharboe May 17, 2023
Collaborator Author

maliberty May 17, 2023
Maintainer

oharboe
May 17, 2023
Collaborator Author

maliberty
May 18, 2023
Maintainer

oharboe
May 18, 2023
Collaborator Author