Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add formatting steps to the pull request template #5605

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Supriyasus
Copy link

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized it.
  • All filenames are in PascalCase.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
  • All new code is formatted with clang-format -i --style=file path/to/your/file.java

@codecov-commenter
Copy link

codecov-commenter commented Oct 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.51%. Comparing base (e63ba4b) to head (1fc25c3).

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5605      +/-   ##
============================================
+ Coverage     73.50%   73.51%   +0.01%     
- Complexity     5097     5099       +2     
============================================
  Files           657      657              
  Lines         17625    17625              
  Branches       3393     3393              
============================================
+ Hits          12955    12957       +2     
  Misses         4166     4166              
+ Partials        504      502       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@siriak siriak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But we don't use neither Black nor Flake8 in our CI pipelines, why are you suggesting using them?

Copy link

github-actions bot commented Nov 7, 2024

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contribution!

@github-actions github-actions bot added the stale label Nov 7, 2024
@github-actions github-actions bot removed the stale label Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants