-
Notifications
You must be signed in to change notification settings - Fork 19.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added surface area calculation for pyramid #6063
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6063 +/- ##
============================================
- Coverage 73.42% 73.39% -0.03%
Complexity 5078 5078
============================================
Files 656 656
Lines 17617 17624 +7
Branches 3394 3395 +1
============================================
Hits 12936 12936
- Misses 4180 4187 +7
Partials 501 501 ☔ View full report in Codecov by Sentry. |
*/ | ||
public static double surfaceAreaPyramid(final double sideLength, final double slantHeight) { | ||
if (sideLength <= 0) { | ||
throw new IllegalArgumentException("Must be a positive sideLength"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is good
if (slantHeight <= 0) { | ||
throw new IllegalArgumentException("Must be a positive slantHeight"); | ||
} | ||
double baseArea = sideLength * sideLength; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix PR checks and add JUnit tests
clang-format -i --style=file path/to/your/file.java