Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crypto-helper page: improve krb output: integrate SimpleOutput component #46

Open
TheBestTvarynka opened this issue Jul 27, 2023 · 0 comments
Labels
crypto-helper Changes in the crypto-helper page enhancement Changes that affects all report or any general component good-first-issue If you want to start contributing into this project then it's a good chise to try refactoring just refactoring. no any new features.

Comments

@TheBestTvarynka
Copy link
Owner

image

at the current moment, we use a custom output component for the output of the krb cipher: https://github.com/TheBestTvarynka/crypto-helper/blob/main/src/crypto_helper/output/krb.rs#L17

But it's obviously better to integrate the SimpleOutput (https://github.com/TheBestTvarynka/crypto-helper/blob/main/src/common/simple_output.rs) component into it. In such a way we'll be able to see output bytes in different representations

@TheBestTvarynka TheBestTvarynka added enhancement Changes that affects all report or any general component good-first-issue If you want to start contributing into this project then it's a good chise to try crypto-helper Changes in the crypto-helper page refactoring just refactoring. no any new features. labels Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
crypto-helper Changes in the crypto-helper page enhancement Changes that affects all report or any general component good-first-issue If you want to start contributing into this project then it's a good chise to try refactoring just refactoring. no any new features.
Projects
None yet
Development

No branches or pull requests

1 participant