Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

G3-274: Update annotator get_ncbo_link function to use requests #20

Conversation

bergsalex
Copy link
Collaborator

@bergsalex bergsalex commented Sep 16, 2024

This PR improves the NCBO annotator code that was erroring out by:

  • Switching from urllib to requests,
  • Adding more helpful logging information, and
  • Increasing the gunicorn timeout.

This has shown some improved performance in testing, and so I'd like to get these changes merged and available.

@bergsalex bergsalex temporarily deployed to jax-cluster-dev-10--dev September 16, 2024 11:29 — with GitHub Actions Inactive
@bergsalex bergsalex temporarily deployed to jax-cluster-dev-10--dev September 16, 2024 13:10 — with GitHub Actions Inactive
@bergsalex bergsalex temporarily deployed to jax-cluster-dev-10--dev September 16, 2024 13:49 — with GitHub Actions Inactive
@bergsalex bergsalex temporarily deployed to jax-cluster-dev-10--dev September 16, 2024 17:24 — with GitHub Actions Inactive
@bergsalex bergsalex temporarily deployed to jax-cluster-dev-10--dev September 17, 2024 13:35 — with GitHub Actions Inactive
@bergsalex bergsalex merged commit a19f8ce into main Sep 17, 2024
2 checks passed
@bergsalex bergsalex deleted the G3-274-the-annotator-in-production-geneweaver-legacy-is-broken-on-geneset-upload branch September 24, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants